From: Kent Overstreet <koverstreet@google.com>
To: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Cc: Kent Overstreet <koverstreet@google.com>,
tejun@google.com, agk@redhat.com, dan.j.williams@intel.com
Subject: [Bcache v14 01/16] Revert "rw_semaphore: remove up/down_read_non_owner"
Date: Tue, 12 Jun 2012 08:39:07 -0700 [thread overview]
Message-ID: <1339515562-14638-2-git-send-email-koverstreet@google.com> (raw)
In-Reply-To: <1339515562-14638-1-git-send-email-koverstreet@google.com>
This reverts commit 11b80f459adaf91a712f95e7734a17655a36bf30.
Signed-off-by: Kent Overstreet <koverstreet@google.com>
---
include/linux/rwsem.h | 10 ++++++++++
kernel/rwsem.c | 16 ++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 54bd7cd..ddfe46d 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -125,9 +125,19 @@ extern void downgrade_write(struct rw_semaphore *sem);
*/
extern void down_read_nested(struct rw_semaphore *sem, int subclass);
extern void down_write_nested(struct rw_semaphore *sem, int subclass);
+/*
+ * Take/release a lock when not the owner will release it.
+ *
+ * [ This API should be avoided as much as possible - the
+ * proper abstraction for this case is completions. ]
+ */
+extern void down_read_non_owner(struct rw_semaphore *sem);
+extern void up_read_non_owner(struct rw_semaphore *sem);
#else
# define down_read_nested(sem, subclass) down_read(sem)
# define down_write_nested(sem, subclass) down_write(sem)
+# define down_read_non_owner(sem) down_read(sem)
+# define up_read_non_owner(sem) up_read(sem)
#endif
#endif /* _LINUX_RWSEM_H */
diff --git a/kernel/rwsem.c b/kernel/rwsem.c
index 6850f53..78b7915 100644
--- a/kernel/rwsem.c
+++ b/kernel/rwsem.c
@@ -116,6 +116,15 @@ void down_read_nested(struct rw_semaphore *sem, int subclass)
EXPORT_SYMBOL(down_read_nested);
+void down_read_non_owner(struct rw_semaphore *sem)
+{
+ might_sleep();
+
+ __down_read(sem);
+}
+
+EXPORT_SYMBOL(down_read_non_owner);
+
void down_write_nested(struct rw_semaphore *sem, int subclass)
{
might_sleep();
@@ -126,6 +135,13 @@ void down_write_nested(struct rw_semaphore *sem, int subclass)
EXPORT_SYMBOL(down_write_nested);
+void up_read_non_owner(struct rw_semaphore *sem)
+{
+ __up_read(sem);
+}
+
+EXPORT_SYMBOL(up_read_non_owner);
+
#endif
--
1.7.9.3.327.g2980b
next prev parent reply other threads:[~2012-06-12 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 15:39 [Bcache v14 00/16] Kent Overstreet
2012-06-12 15:39 ` Kent Overstreet [this message]
2012-06-12 15:39 ` [Bcache v14 02/16] Fix ratelimit macro to compile in c99 mode Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 03/16] Export get_random_int() Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 04/16] Add human-readable units modifier to vsnprintf() Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 05/16] Export blk_fill_rwbs() Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 06/16] Export __lockdep_no_validate__ Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 07/16] Closures Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 08/16] bcache: Documentation, and changes to generic code Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 09/16] bcache: Generic utility code Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 10/16] bcache: Superblock/initialization/sysfs code Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 11/16] bcache: Core btree code Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 12/16] bcache: Bset code (lookups within a btree node) Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 13/16] bcache: Journalling Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 14/16] bcache: Request, io and allocation code Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 15/16] bcache: Writeback, copying garbage collection Kent Overstreet
2012-06-12 15:39 ` [Bcache v14 16/16] bcache: Debug and tracing code Kent Overstreet
2012-06-12 16:50 ` Joe Perches
2012-06-12 17:24 ` Kent Overstreet
2012-06-12 17:35 ` Joe Perches
2012-06-12 17:45 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339515562-14638-2-git-send-email-koverstreet@google.com \
--to=koverstreet@google.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tejun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®