From: Tyler Hicks <tyhicks@canonical.com>
To: ecryptfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH 0/3] eCryptfs: Fix and simplify messaging code
Date: Tue, 12 Jun 2012 17:05:37 -0700 [thread overview]
Message-ID: <1339545940-11736-1-git-send-email-tyhicks@canonical.com> (raw)
In-Reply-To: <1338061161.4284.16.camel@lappy>
Sasha Levin discovered a bug when fuzzing /dev/ecryptfs. The code behind
/dev/ecryptfs never considered the possibility that file descriptors may be
inherited or passed to other processes. Additionally, far too many BUG() calls
were used throughout the messaging code.
The eCryptfs messaging code was originally implemented using netlink. Several
years ago, it was converted to a miscdev driver but it retained some of the
concepts that were specific to netlink.
The first patch is a minimalist approach at solving the bug Sasha discovered.
The second patch removes some cruft. The last patch leverages the file-based
miscdev approach to simplify the implementation.
Tyler
---
fs/ecryptfs/ecryptfs_kernel.h | 22 ++-----
fs/ecryptfs/messaging.c | 136 +++++------------------------------------
fs/ecryptfs/miscdev.c | 91 ++++++++-------------------
3 files changed, 48 insertions(+), 201 deletions(-)
next prev parent reply other threads:[~2012-06-13 0:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 19:39 ecryptfs: kernel BUG at fs/ecryptfs/miscdev.c:52 Sasha Levin
2012-06-07 0:41 ` Sasha Levin
2012-06-13 0:05 ` Tyler Hicks [this message]
2012-06-13 0:05 ` [PATCH 1/3] eCryptfs: Gracefully refuse miscdev file ops on inherited/passed files Tyler Hicks
2012-06-22 17:47 ` Sasha Levin
2012-06-22 17:58 ` Tyler Hicks
2012-06-13 0:05 ` [PATCH 2/3] eCryptfs: Remove unused messaging declarations and function Tyler Hicks
2012-06-13 0:05 ` [PATCH 3/3] eCryptfs: Make all miscdev functions use daemon ptr in file private_data Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339545940-11736-1-git-send-email-tyhicks@canonical.com \
--to=tyhicks@canonical.com \
--cc=ecryptfs@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®