From: Ning Jiang <ning.n.jiang@gmail.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Ning Jiang <ning.n.jiang@gmail.com>
Subject: [PATCH 2/2] genirq: Resend nested irq's ancestor irq
Date: Thu, 14 Jun 2012 16:31:37 +0800 [thread overview]
Message-ID: <1339662697-4600-2-git-send-email-ning.n.jiang@gmail.com> (raw)
In-Reply-To: <1339662697-4600-1-git-send-email-ning.n.jiang@gmail.com>
We'll set IRQS_PENDING for handle_nested_irq if it's disabled. When
it's re-enabled later on, check_irq_resend() will detect this flag
and trigger the software resend mechanism. resend_irqs() will call
desc->handle_irq() directly to process this interrupt, hence the
irq_nested_primary_handler() will be called for the nested irq which
gives us a warning.
If we need to resend a nested interrupt, we have to trace all the
way back to its ancestor and trigger ancestor's irq flow handler.
Signed-off-by: Ning Jiang <ning.n.jiang@gmail.com>
---
kernel/irq/resend.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c
index 6454db7..dcfc1b5 100644
--- a/kernel/irq/resend.c
+++ b/kernel/irq/resend.c
@@ -74,6 +74,11 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq)
if (!desc->irq_data.chip->irq_retrigger ||
!desc->irq_data.chip->irq_retrigger(&desc->irq_data)) {
#ifdef CONFIG_HARDIRQS_SW_RESEND
+ while (irq_settings_is_nested_thread(desc) &&
+ (desc->irq_data.parent_irq != NO_IRQ)) {
+ irq = desc->irq_data.parent_irq;
+ desc = irq_to_desc(irq);
+ }
/* Set it pending and activate the softirq: */
set_bit(irq, irqs_resend);
tasklet_schedule(&resend_tasklet);
--
1.7.1
next prev parent reply other threads:[~2012-06-14 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:31 [PATCH 1/2] genirq: Introduce parent and children concept for IRQ Ning Jiang
2012-06-14 8:31 ` Ning Jiang [this message]
2012-06-14 10:34 ` [PATCH 2/2] genirq: Resend nested irq's ancestor irq Thomas Gleixner
2012-06-15 6:29 ` Ning Jiang
2012-06-15 12:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339662697-4600-2-git-send-email-ning.n.jiang@gmail.com \
--to=ning.n.jiang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®