mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Hans Rosenfeld <hans.rosenfeld@amd.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	tglx@linutronix.de, robert.richter@amd.com,
	andreas.herrmann3@amd.com
Subject: Re: [RFC] x86, fpu: unify signal handling code paths for x86 and x86_64 kernels
Date: Thu, 14 Jun 2012 13:45:34 -0700	[thread overview]
Message-ID: <1339706734.3475.34.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <20120614143727.GF7922@escobedo.osrc.amd.com>

On Thu, 2012-06-14 at 16:37 +0200, Hans Rosenfeld wrote:
> Thank you for working on this.
> 
> I didn't see anything obviously wrong in a quick review of this code,
> but this stuff is too complex for this to mean anything :)
> 
> I ran a quick test of your code. I found a signal frame corruption when
> running a 32bit test program on a 64bit kernel. I didn't try to find out
> why it failed, but I'll send you the test program in a private mail so
> you can look at it yourself.
> 

Ok. The problem was that I was using is_ia32_task() (which uses
TS_COMPAT) to check if the task is a compat task or not. And that flag
is not set during the signal delivery paths for the compat task.

I guess I should be using TIF_IA32 check instead. Using TIF_IA32 check
makes your test case run fine.

Will update it accordingly.

thanks,
suresh


  reply	other threads:[~2012-06-14 20:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13  0:03 Suresh Siddha
2012-06-13  0:17 ` H. Peter Anvin
2012-06-14 14:37 ` Hans Rosenfeld
2012-06-14 20:45   ` Suresh Siddha [this message]
2012-06-15  0:10   ` Suresh Siddha
2012-06-15  0:16     ` H. Peter Anvin
2012-06-15  1:07       ` Suresh Siddha
2012-06-15  1:13         ` H. Peter Anvin
2012-06-15  1:16           ` Suresh Siddha
2012-06-15  1:17             ` H. Peter Anvin
2012-06-16  3:14         ` [tip:x86/urgent] x86, compat: Use test_thread_flag(TIF_IA32) in compat signal delivery tip-bot for Suresh Siddha
2012-06-14 20:48 ` [RFC] x86, fpu: unify signal handling code paths for x86 and x86_64 kernels H. Peter Anvin
2012-06-14 20:49   ` Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339706734.3475.34.camel@sbsiddha-desk.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=hans.rosenfeld@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®