From: Steven Rostedt <rostedt@goodmis.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Anton Vorontsov <anton.vorontsov@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
"arve@android.com" <arve@android.com>,
Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
"kernel-team@android.com" <kernel-team@android.com>
Subject: RE: [PATCH 3/6] pstore: Add persistent function tracing
Date: Fri, 15 Jun 2012 17:55:08 -0400 [thread overview]
Message-ID: <1339797308.25903.8.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1931FC30@ORSMSX104.amr.corp.intel.com>
On Fri, 2012-06-15 at 21:40 +0000, Luck, Tony wrote:
> > We store the log in a binary format and then decode it at read time.
>
> What are the advantages of this compared to creating the human
> readable text and saving a blob of text?
With function tracing the impact to performance is tremendous. Just
recording two long words is a 130% hit to performance. Now multiply that
to recording strings.
>
> What does this "binary format" look like? Will it ever change?
> Remember that we may reboot to a different kernel - so we have
> to be really sure that the newer (or older) version can do the decode.
Good question.
-- Steve
next prev parent reply other threads:[~2012-06-15 21:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 17:07 [PATCH v2 0/6] Function tracing support for pstore Anton Vorontsov
2012-06-15 17:08 ` [PATCH 1/6] tracing: Fix initialization failure path in tracing_set_tracer() Anton Vorontsov
2012-06-15 22:00 ` Steven Rostedt
2012-06-15 17:08 ` [PATCH 2/6] pstore: Introduce write_buf backend callback Anton Vorontsov
2012-06-15 17:08 ` [PATCH 3/6] pstore: Add persistent function tracing Anton Vorontsov
2012-06-15 21:40 ` Luck, Tony
2012-06-15 21:55 ` Steven Rostedt [this message]
2012-06-15 22:00 ` Luck, Tony
2012-06-15 22:09 ` Colin Cross
2012-06-15 22:10 ` Steven Rostedt
2012-06-15 22:19 ` Luck, Tony
2012-06-15 22:23 ` Colin Cross
2012-06-15 22:37 ` Luck, Tony
2012-06-15 22:42 ` Steven Rostedt
2012-06-15 22:28 ` Steven Rostedt
2012-06-15 17:08 ` [PATCH 4/6] tracing/function: Introduce persistent trace option Anton Vorontsov
2012-06-15 17:08 ` [PATCH 5/6] pstore/ram: Convert to write_buf callback Anton Vorontsov
2012-06-15 17:08 ` [PATCH 6/6] pstore/ram: Add ftrace messages handling Anton Vorontsov
2012-06-15 21:28 ` [PATCH v2 0/6] Function tracing support for pstore Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339797308.25903.8.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®