From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758462Ab2FOWpS (ORCPT ); Fri, 15 Jun 2012 18:45:18 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:2629 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758332Ab2FOWpN (ORCPT ); Fri, 15 Jun 2012 18:45:13 -0400 X-Authority-Analysis: v=2.0 cv=D8PF24tj c=1 sm=0 a=ZycB6UtQUfgMyuk2+PxD7w==:17 a=XQbtiDEiEegA:10 a=ag8JG7z7P3cA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=ayC55rCoAAAA:8 a=qLiaGDU3DqCYzKpQLwIA:9 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.80.29 Message-ID: <1339800312.25903.29.camel@gandalf.stny.rr.com> Subject: Re: [PATCH 3/3] tools lib traceevent: Introduce pevent_strerror From: Steven Rostedt To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , LKML , Frederic Weisbecker , Namhyung Kim Date: Fri, 15 Jun 2012 18:45:12 -0400 In-Reply-To: <87k3z843i9.fsf@gmail.com> References: <1339486959-25241-1-git-send-email-namhyung@kernel.org> <1339486959-25241-4-git-send-email-namhyung@kernel.org> <1339763971.13377.370.camel@gandalf.stny.rr.com> <87k3z843i9.fsf@gmail.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.2.2-1+b1 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2012-06-16 at 07:25 +0900, Namhyung Kim wrote: > Steven Rostedt writes: > > > On Tue, 2012-06-12 at 16:42 +0900, Namhyung Kim wrote: > > > >> +/* > >> + * This must have a same ordering as the enum pevent_errno. > >> + */ > >> +static const char * const pevent_error_str[] = { > >> + "failed to allocate memory", > >> + "failed to parse event", > >> + "failed to read event id", > >> + "failed to read event format", > >> + "failed to read event print fmt", > >> + "failed to allocate field name for ftrace", > >> +}; > >> + > > > > Here's a little macro trick to keep the strings and enums always in > > sync: > > > > #define __PEVENT_ERRNO_CODES \ > > _C(PEVENT_ERRNO__MEM_ALLOC_FAILED, "failed to allocate memory"), \ > > _C(PEVENT_ERRNO__PARSE_EVENT_FAILED, "failed to parse event"), \ > > _C(PEVENT_ERRNO__READ_ID_FAILED, "failed to read event id"), \ > > _C(PEVENT_ERRNO__READ_FORMAT_FAILED, "failed to read event format"), \ > > _C(PEVENT_ERRNO__READ_PRINT_FAILED, "failed to read event print fmt"),\ > > _C(PEVENT_ERRNO__OLD_FTRACE_ARG_FAILED,"failed to allocate field name for ftrace"), > > > > #undef _C > > #define _C(a,b) b > > static const char * const pevent_error_str[] = { __PEVENT_ERROR_CODES }; > > > > Cool. Maybe even shorter: > > #define __PEVENT_ERRNO_CODES \ > _C(MEM_ALLOC_FAILED, "failed to allocate memory"), \ > _C(PARSE_EVENT_FAILED, "failed to parse event"), \ > _C(READ_ID_FAILED, "failed to read event id"), \ > _C(READ_FORMAT_FAILED, "failed to read event format"), \ > _C(READ_PRINT_FAILED, "failed to read event print fmt"), \ > _C(OLD_FTRACE_ARG_FAILED, "failed to allocate field name for ftrace"), > > #undef _C > #define _C(a,b) PEVENT_ERRNO__ ## a I think you wanted b on this one. ;-) > static const char * const pevent_error_str[] = { __PEVENT_ERROR_CODES }; > > But it make them less grep-able? Yeah, that is a problem, although we could perhaps teach ctags and etags how to find them. -- Steve