From: Bojan Smojver <bojan@rexursive.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Borislav Petkov <bp@alien8.de>,
Alan Stern <stern@rowland.harvard.edu>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: In kernel hibernation, suspend to both
Date: Mon, 18 Jun 2012 10:33:06 +1000 [thread overview]
Message-ID: <1339979586.1666.13.camel@shrek.rexursive.com> (raw)
In-Reply-To: <201206172221.55493.rjw@sisk.pl>
On Sun, 2012-06-17 at 22:21 +0200, Rafael J. Wysocki wrote:
> Yeah, that will do.
Something like this maybe. I didn't really test this, so Borislav,
please let me know whether this is something that may works for you.
-------------------------
kernel/power/swap.c | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 11e22c0..c24d354 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -448,9 +448,9 @@ static int save_image(struct swap_map_handle *handle,
struct timeval start;
struct timeval stop;
- printk(KERN_INFO "PM: Saving image data pages (%u pages) ... ",
+ printk(KERN_INFO "PM: Saving image data pages (%u pages) ",
nr_to_write);
- m = nr_to_write / 100;
+ m = nr_to_write / 10;
if (!m)
m = 1;
nr_pages = 0;
@@ -464,7 +464,7 @@ static int save_image(struct swap_map_handle *handle,
if (ret)
break;
if (!(nr_pages % m))
- printk(KERN_CONT "\b\b\b\b%3d%%", nr_pages / m);
+ printk(KERN_CONT ".");
nr_pages++;
}
err2 = hib_wait_on_bio_chain(&bio);
@@ -472,7 +472,7 @@ static int save_image(struct swap_map_handle *handle,
if (!ret)
ret = err2;
if (!ret)
- printk(KERN_CONT "\b\b\b\bdone\n");
+ printk(KERN_CONT " done.\n");
else
printk(KERN_CONT "\n");
swsusp_show_speed(&start, &stop, nr_to_write, "Wrote");
@@ -668,9 +668,9 @@ static int save_image_lzo(struct swap_map_handle *handle,
printk(KERN_INFO
"PM: Using %u thread(s) for compression.\n"
- "PM: Compressing and saving image data (%u pages) ... ",
+ "PM: Compressing and saving image data (%u pages) ",
nr_threads, nr_to_write);
- m = nr_to_write / 100;
+ m = nr_to_write / 10;
if (!m)
m = 1;
nr_pages = 0;
@@ -690,8 +690,7 @@ static int save_image_lzo(struct swap_map_handle *handle,
data_of(*snapshot), PAGE_SIZE);
if (!(nr_pages % m))
- printk(KERN_CONT "\b\b\b\b%3d%%",
- nr_pages / m);
+ printk(KERN_CONT ".");
nr_pages++;
}
if (!off)
@@ -762,7 +761,7 @@ out_finish:
if (!ret)
ret = err2;
if (!ret) {
- printk(KERN_CONT "\b\b\b\bdone\n");
+ printk(KERN_CONT " done.\n");
} else {
printk(KERN_CONT "\n");
}
@@ -973,9 +972,9 @@ static int load_image(struct swap_map_handle *handle,
int err2;
unsigned nr_pages;
- printk(KERN_INFO "PM: Loading image data pages (%u pages) ... ",
+ printk(KERN_INFO "PM: Loading image data pages (%u pages) ",
nr_to_read);
- m = nr_to_read / 100;
+ m = nr_to_read / 10;
if (!m)
m = 1;
nr_pages = 0;
@@ -993,7 +992,7 @@ static int load_image(struct swap_map_handle *handle,
if (ret)
break;
if (!(nr_pages % m))
- printk("\b\b\b\b%3d%%", nr_pages / m);
+ printk(".");
nr_pages++;
}
err2 = hib_wait_on_bio_chain(&bio);
@@ -1001,7 +1000,7 @@ static int load_image(struct swap_map_handle *handle,
if (!ret)
ret = err2;
if (!ret) {
- printk("\b\b\b\bdone\n");
+ printk(" done.\n");
snapshot_write_finalize(snapshot);
if (!snapshot_image_loaded(snapshot))
ret = -ENODATA;
@@ -1185,9 +1184,9 @@ static int load_image_lzo(struct swap_map_handle *handle,
printk(KERN_INFO
"PM: Using %u thread(s) for decompression.\n"
- "PM: Loading and decompressing image data (%u pages) ... ",
+ "PM: Loading and decompressing image data (%u pages) ",
nr_threads, nr_to_read);
- m = nr_to_read / 100;
+ m = nr_to_read / 10;
if (!m)
m = 1;
nr_pages = 0;
@@ -1319,7 +1318,7 @@ static int load_image_lzo(struct swap_map_handle *handle,
data[thr].unc + off, PAGE_SIZE);
if (!(nr_pages % m))
- printk("\b\b\b\b%3d%%", nr_pages / m);
+ printk(".");
nr_pages++;
ret = snapshot_write_next(snapshot);
@@ -1344,7 +1343,7 @@ out_finish:
}
do_gettimeofday(&stop);
if (!ret) {
- printk("\b\b\b\bdone\n");
+ printk(" done.\n");
snapshot_write_finalize(snapshot);
if (!snapshot_image_loaded(snapshot))
ret = -ENODATA;
-------------------------
--
Bojan
next prev parent reply other threads:[~2012-06-18 0:33 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 22:22 Bojan Smojver
2012-05-09 8:10 ` Srivatsa S. Bhat
2012-05-09 10:49 ` Bojan Smojver
2012-05-09 11:11 ` Bojan Smojver
2012-05-13 23:32 ` Srivatsa S. Bhat
2012-05-14 1:02 ` Bojan Smojver
2012-05-14 2:25 ` Alan Stern
2012-05-14 2:37 ` Bojan Smojver
2012-05-14 2:46 ` Bojan Smojver
2012-05-14 2:58 ` Bojan Smojver
2012-05-14 7:45 ` Bojan Smojver
2012-05-14 11:11 ` Bojan Smojver
2012-05-14 11:47 ` Bojan Smojver
2012-05-14 23:59 ` Bojan Smojver
2012-05-15 14:26 ` Alan Stern
2012-05-15 14:35 ` Srivatsa S. Bhat
2012-05-15 17:42 ` Rafael J. Wysocki
2012-05-15 18:23 ` Srivatsa S. Bhat
2012-05-15 22:23 ` Bojan Smojver
2012-05-21 4:38 ` Bojan Smojver
2012-05-21 8:18 ` Borislav Petkov
2012-05-21 13:18 ` Rafael J. Wysocki
2012-05-21 21:43 ` Bojan Smojver
2012-05-21 21:53 ` Rafael J. Wysocki
2012-05-21 21:55 ` Bojan Smojver
2012-05-24 14:51 ` Borislav Petkov
2012-05-25 2:02 ` Bojan Smojver
2012-05-31 16:23 ` Borislav Petkov
2012-06-01 2:03 ` Bojan Smojver
2012-06-01 8:48 ` Borislav Petkov
2012-06-01 8:57 ` Bojan Smojver
2012-06-01 9:03 ` Borislav Petkov
2012-06-16 13:59 ` Rafael J. Wysocki
2012-06-16 17:39 ` Borislav Petkov
2012-06-16 19:17 ` Rafael J. Wysocki
2012-06-16 20:09 ` Bojan Smojver
2012-06-16 20:19 ` Alan Stern
2012-06-16 23:07 ` Borislav Petkov
2012-06-17 3:21 ` Bojan Smojver
2012-06-17 10:31 ` Borislav Petkov
2012-06-17 20:21 ` Rafael J. Wysocki
2012-06-18 0:33 ` Bojan Smojver [this message]
2012-06-18 12:32 ` Borislav Petkov
2012-06-18 20:29 ` Rafael J. Wysocki
2012-06-18 21:08 ` Bojan Smojver
2012-06-18 21:28 ` Rafael J. Wysocki
2012-06-19 2:09 ` Bojan Smojver
2012-06-19 14:21 ` Borislav Petkov
2012-06-19 14:32 ` Bojan Smojver
2012-06-19 20:23 ` Rafael J. Wysocki
2012-06-19 21:32 ` Bojan Smojver
2012-06-19 22:35 ` Bojan Smojver
2012-05-12 21:47 ` Rafael J. Wysocki
2012-05-13 1:37 ` Bojan Smojver
2012-05-13 13:10 ` Rafael J. Wysocki
2012-05-13 23:18 ` Bojan Smojver
2012-05-13 23:49 ` Srivatsa S. Bhat
2012-05-14 0:39 ` Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339979586.1666.13.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome