From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH v2 1/5] tools lib traceevent: Replace malloc_or_die to plain calloc in alloc_event()
Date: Mon, 18 Jun 2012 11:50:47 +0900 [thread overview]
Message-ID: <1339987851-22491-1-git-send-email-namhyung@kernel.org> (raw)
From: Namhyung Kim <namhyung.kim@lge.com>
Because the only caller of the alloc_event()
(pevent_parse_event) checks return value properly
and all it does after allocation is initializing,
it can be changed to use plain calloc.
Thanks to Steven for suggesting this simpler way.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-wagq5qbdy1mytvjkrjbqt095@git.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/lib/traceevent/event-parse.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index c471075e4974..4f667fdc5fae 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -619,12 +619,7 @@ void pevent_print_printk(struct pevent *pevent)
static struct event_format *alloc_event(void)
{
- struct event_format *event;
-
- event = malloc_or_die(sizeof(*event));
- memset(event, 0, sizeof(*event));
-
- return event;
+ return calloc(1, sizeof(struct event_format));
}
static void add_event(struct pevent *pevent, struct event_format *event)
--
1.7.10.2
next reply other threads:[~2012-06-18 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 2:50 Namhyung Kim [this message]
2012-06-18 2:50 ` [PATCH v2 2/5] tools lib traceevent: Do not link broken field arg for an old ftrace event Namhyung Kim
2012-06-18 2:50 ` [PATCH v2 3/5] tools lib traceevent: Introduce pevent_errno Namhyung Kim
2012-06-18 2:50 ` [PATCH v2 4/5] tools lib traceevent: Introduce pevent_strerror Namhyung Kim
2012-06-18 13:41 ` Steven Rostedt
2012-06-18 2:50 ` [PATCH v2 5/5] scripts/tags.sh: Teach [ce]tags about libtraceeevent error codes Namhyung Kim
2012-06-18 13:44 ` Steven Rostedt
2012-07-26 12:24 ` Michal Marek
2012-06-18 13:37 ` [PATCH v2 1/5] tools lib traceevent: Replace malloc_or_die to plain calloc in alloc_event() Steven Rostedt
2012-06-18 13:45 ` Steven Rostedt
2012-06-18 14:06 ` Arnaldo Carvalho de Melo
2012-06-19 8:02 ` Namhyung Kim
2012-06-19 12:30 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339987851-22491-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®