From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753675Ab2FSB0G (ORCPT ); Mon, 18 Jun 2012 21:26:06 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:10475 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752459Ab2FSB0E (ORCPT ); Mon, 18 Jun 2012 21:26:04 -0400 X-Authority-Analysis: v=2.0 cv=D8PF24tj c=1 sm=0 a=ZycB6UtQUfgMyuk2+PxD7w==:17 a=XQbtiDEiEegA:10 a=ARy8Wg5PTaYA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=ayC55rCoAAAA:8 a=Sf_JpM12CPt-B493w5AA:9 a=PUjeQqilurYA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.80.29 Message-ID: <1340069162.25903.176.camel@gandalf.stny.rr.com> Subject: Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins From: Steven Rostedt To: Namhyung Kim Cc: David Ahern , acme@ghostprotocols.net, linux-kernel@vger.kernel.org, weisbec@gmail.com, namhyung.kim@lge.com, mingo@kernel.org, peterz@infradead.org Date: Mon, 18 Jun 2012 21:26:02 -0400 In-Reply-To: <878vfkhzr8.fsf@sejong.aot.lge.com> References: <1339695333-64591-1-git-send-email-dsahern@gmail.com> <87lijlhv9v.fsf@sejong.aot.lge.com> <4FDF3D5C.1030209@gmail.com> <87d34wi0y3.fsf@sejong.aot.lge.com> <1340067793.25903.158.camel@gandalf.stny.rr.com> <878vfkhzr8.fsf@sejong.aot.lge.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.2.2-1+b1 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-06-19 at 10:11 +0900, Namhyung Kim wrote: > > trace-cmd report -N > > [...] > > kvm-6172 [000] 14669573.114126: kvm_entry: vcpu 0 > > kvm-6172 [000] 14669573.114127: kvm_exit: [FAILED TO PARSE] exit_reason=30 guest_rip=0xffff357a isa=1 info1=217841672 info2=0 > > kvm-6172 [000] 14669573.114130: kvm_emulate_insn: [FAILED TO PARSE] rip=4294915450 csbase=0 len=1 insn=ì[ÃWVS<89>Ã<89>Ö¨^Gu^Q^O^E flags=5 failed=0 > > kvm-6172 [000] 14669573.114130: kvm_pio: pio_read at 0xcfc size 1 count 1 > > kvm-6172 [000] 14669573.114131: kvm_userspace_exit: reason KVM_EXIT_IO (2) > > kvm-6172 [000] 14669573.114134: kvm_entry: vcpu 0 > > > > What I want to do is make it not to fail with default print_fmt (ie. w/o > plugin support). IOW using a plugin to improve things like above is > good, but not using it shouldn't break/fail anything. So I think fixing > the TP_printk is needed. I'm not sure its broken anymore per-say. As I just ran this without plugins (with the -N switch) and it doesn't break. It sends out some nasty warnings, but continues on its happy way with a warning that it '[FAILED TO PARSE]'. And some warnings in the beginning. But it doesn't totally fail. We could probably clean it up a bit too. What it does above is simply print out the raw data and lists the fields. The problem with modifying the TP_printk() is that this is also used by raw tracing (the /debug/tracing/trace file). Without using tools. The TP_printk() is really for that. The plugins is the way for tools to handle it. -- Steve