mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>, RT <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	leroy christophe <christophe.leroy@c-s.fr>,
	Iratxo Pichel Ortiz <ipichel@albentia.com>,
	David Garcia <dgarcia@albentia.com>
Subject: [PATCH][RT] spinlock: Add include for BUG() in spinlock_rt.h
Date: Thu, 21 Jun 2012 09:37:58 -0400	[thread overview]
Message-ID: <1340285878.27036.138.camel@gandalf.stny.rr.com> (raw)

spinlock_rt.h references BUG(), but it does not include bug.h, and on
some architectures (powerpc) this can cause a build failure.

Reported-by: Iratxo Pichel Ortiz <ipichel@albentia.com>
Reported-by: leroy christophe <christophe.leroy@c-s.fr>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
----
[ Thomas, can you add this patch to your queue so that I can add it to
stable. Please, let me know when you have. Thanks! ]

diff --git a/include/linux/spinlock_rt.h b/include/linux/spinlock_rt.h
index 3b555b4..0618387 100644
--- a/include/linux/spinlock_rt.h
+++ b/include/linux/spinlock_rt.h
@@ -5,6 +5,8 @@
 #error Do not include directly. Use spinlock.h
 #endif
 
+#include <linux/bug.h>
+
 extern void
 __rt_spin_lock_init(spinlock_t *lock, char *name, struct lock_class_key *key);
 



             reply	other threads:[~2012-06-21 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 13:37 Steven Rostedt [this message]
2012-06-22  9:08 ` Thomas Gleixner
2012-06-22 10:49   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340285878.27036.138.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=dgarcia@albentia.com \
    --cc=ipichel@albentia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®