Re: [PATCH] ring-buffer: fix uninitialized read_stamp

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 2012-06-18 at 16:02 -0700, David Sharp wrote:
> This fixes a scenario in which trace_pipe_raw will return events with invalid
> timestamps when events are copied out one at a time (instead of swapping out
> the reader page with a spare page). In this scenario, ring_buffer_read_page()
> uses cpu_buffer->read_stamp to keep track of the time of the earliest event.
> However, cpu_buffer->read_stamp was not always updated. The only function that
> sets read_stamp to a new valid value is rb_reset_reader_page(), which is called
> only by rb_get_reader_page(). rb_reset_reader_page() was not called when there
> is data immediately available on the page to read (read < rb_page_size()). This
> is the bug.

Hi David,

Thanks for the reminder, I'll be looking at it today.

Do you believe that this is an urgent fix and should be marked for
stable, or do you think it can wait till 3.6? If you think it should be
marked for stable, then it should be pushed for 3.5.

-- Steve