From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761884Ab2FVJK0 (ORCPT ); Fri, 22 Jun 2012 05:10:26 -0400 Received: from smtprelay-b21.telenor.se ([195.54.99.212]:36812 "EHLO smtprelay-b21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761816Ab2FVJKY (ORCPT ); Fri, 22 Jun 2012 05:10:24 -0400 X-SENDER-IP: [85.230.168.62] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: As5NAMo15E9V5qg+PGdsb2JhbABFihWrTBkBAQEBNzSCdRMBAQ4YEXEKGhOID7okFJEcA5sRjH0 X-IronPort-AV: E=Sophos;i="4.77,457,1336341600"; d="scan'208";a="363406076" From: "Henrik Rydberg" To: Jiri Kosina Cc: Dmitry Torokhov , Jan Beulich , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Henrik Rydberg Subject: [PATCH] HID: Fix the Kconfig option for generic device handling Date: Fri, 22 Jun 2012 11:13:10 +0200 Message-Id: <1340356390-4614-1-git-send-email-rydberg@euromail.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The generic HID driver is obviously not a special driver, so move it outside of the special drivers menu. Explain the usage and make the default follow the HID setting. This should simplify migration from older kernels. Reported-by: Jan Beulich Signed-off-by: Henrik Rydberg --- Hi Jiri, As pointed out by Jan Beulich, the generic hid driver Kconfig option is confusing. This patch ought to fix most of the concerns. For 3.5. Thanks, Henrik drivers/hid/Kconfig | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 034c80a..fabf817 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -61,21 +61,22 @@ config HIDRAW source "drivers/hid/usbhid/Kconfig" -menu "Special HID drivers" - depends on HID - config HID_GENERIC tristate "Generic HID driver" depends on HID - default y + default HID ---help--- - Support for generic HID devices. + Support for generic devices on the HID bus. This includes most + keyboards and mice, joysticks, tablets and digitizers. To compile this driver as a module, choose M here: the module will be called hid-generic. If unsure, say Y. +menu "Special HID drivers" + depends on HID + config HID_A4TECH tristate "A4 tech mice" if EXPERT depends on USB_HID -- 1.7.10.4