mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ysato@users.sourceforge.jp
Subject: Re: finding unused header files
Date: Fri, 22 Jun 2012 13:03:25 +0200	[thread overview]
Message-ID: <1340363005.1773.86.camel@x61.thuisdomein> (raw)
In-Reply-To: <alpine.DEB.2.02.1206220641150.6493@oneiric>

On Fri, 2012-06-22 at 06:46 -0400, Robert P. J. Day wrote:
> inspired by that last post that located an unused header file under
> arch/h8300, i ran my "find_unused_headers.sh" script on the same
> sub-directory to see what would show up.
> 
>   the script is stupidly conservative and didn't identify that shm.h
> header since *somewhere* in the entire kernel source tree, someone was
> including a file called "shm.h" -- not even for the same architecture.
> like i said, stupidly conservative.
> 
>   but it did find this:
> 
> $ ../s/find_unused_headers.sh arch/h8300
> ===== target_time.h =====
> ./arch/h8300/include/asm/target_time.h
> $
> 
> and i see nothing anywhere in the entire tree that includes a
> target_time.h header under any circumstances.

See my patch "h8300: delete
target_time.h" (https://lkml.org/lkml/2012/6/8/518 ). I don't remember
getting a reply to that message.

>   i should probably do another run of these scripts some day, just to
> see what turns up.

The script I use currently shows almost 200 (potentially) unused
headers. It's not very sophisticated and errs on the safe side (ie, it
must show absolutely no sign of files including the header). I'm not
sure whether a sophisticated approach is actually feasible.

In the last weeks I send patches to remove a few dozen of those 200
headers.


Paul Bolle


  reply	other threads:[~2012-06-22 11:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 10:46 Robert P. J. Day
2012-06-22 11:03 ` Paul Bolle [this message]
2012-06-22 11:31 ` Pádraig Brady
2012-06-22 11:58 ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340363005.1773.86.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®