From: Alexandre Courbot <acourbot@nvidia.com>
To: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] gpio: gpiolib: fix conflicting flag values
Date: Fri, 22 Jun 2012 20:48:56 +0900 [thread overview]
Message-ID: <1340365736-20161-1-git-send-email-acourbot@nvidia.com> (raw)
Commits aca5ce14 and 25553ff0 introduced two new GPIOF_OPEN_DRAIN and
GPIOF_OPEN_SOURCE flags to gpiolib. Unfortunately they happen to be the
same as GPIOF_EXPORT and GPIOF_EXPORT_CHANGEABLE, which causes all gpios
exported at request time to end up open drain and/or open source.
Resolve the conflict by affecting free flags to GPIOF_EXPORT and
GPIOF_EXPORT_CHANGEABLE.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
include/linux/gpio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index f07fc2d..2e31e8b 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -22,8 +22,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)
-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)
--
1.7.11
next reply other threads:[~2012-06-22 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 11:48 Alexandre Courbot [this message]
2012-06-22 11:52 ` Laxman Dewangan
2012-06-22 12:01 ` Alex Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340365736-20161-1-git-send-email-acourbot@nvidia.com \
--to=acourbot@nvidia.com \
--cc=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®