From: Joe Perches <joe@perches.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Matthew Garrett <mjg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg
Date: Sat, 23 Jun 2012 20:06:46 -0700 [thread overview]
Message-ID: <1340507206.7758.30.camel@joe2Laptop> (raw)
In-Reply-To: <20120624004051.GC20885@khazad-dum.debian.net>
On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote:
> On Sun, 17 Jun 2012, Joe Perches wrote:
> > Use a more current logging style.
> >
> > Add #define DEBUG and use pr_debug to enable dynamic debugging.
> > Coalesce formats and align arguments.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Joe, are there any extra procedures required from the user to get the debug
> messages with this patch applied?
No.
The added #define DEBUG makes dynamic_debug emit those
messages automatically. Without the #define DEBUG, then
these tp_[v]dbg calls might not be compiled in at all.
These to_[v]dbg calls can be turned off via the normal
dyn_debug mechanisms.
see: Documentation/dynamic-debug-howto.txt
cheers, Joe
next prev parent reply other threads:[~2012-06-24 3:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 2:25 [PATCH 0/5] printk: Add eliminated_printk Joe Perches
2012-06-18 2:25 ` [PATCH 1/5] printk: Add eliminated_printk macro Joe Perches
2012-06-18 2:25 ` [PATCH 2/5] printk: Convert pr_devel to use eliminated_printk Joe Perches
2012-06-18 2:25 ` [PATCH 3/5] usb: Convert dbg to pr_eliminated and pr_debug Joe Perches
2012-06-18 6:08 ` Paul Mundt
2012-06-18 15:23 ` Greg Kroah-Hartman
2012-06-18 16:07 ` Joe Perches
2012-06-18 16:14 ` Greg Kroah-Hartman
2012-06-18 16:39 ` Joe Perches
2012-06-18 2:25 ` [PATCH 4/5] fujitsu-laptop: Convert dbg_printk and vdbg_printk to fuj_dbg Joe Perches
2012-06-18 7:08 ` Jonathan Woithe
2012-06-18 2:25 ` [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg Joe Perches
2012-06-24 0:40 ` Henrique de Moraes Holschuh
2012-06-24 3:06 ` Joe Perches [this message]
2012-06-24 14:42 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340507206.7758.30.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®