mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Kurtz <djkurtz@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Nick Dyer <nick.dyer@itdev.co.uk>,
	linux-input@vger.kernel.org
Cc: Iiro Valkonen <iiro.valkonen@atmel.com>,
	Benson Leung <bleung@chromium.org>,
	Yufeng Shen <miletus@chromium.org>,
	Olof Johansson <olofj@chromium.org>,
	linux-kernel@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH 01/21 v5] Input: atmel_mxt_ts - derive phys from i2c client adapter
Date: Tue, 26 Jun 2012 14:56:49 +0800	[thread overview]
Message-ID: <1340693829-18665-2-git-send-email-djkurtz@chromium.org> (raw)
In-Reply-To: <1340693829-18665-1-git-send-email-djkurtz@chromium.org>

This allows userspace to more easily distinguish which bus a particular
atmel_mxt_ts device is attached to.

The resulting phys will be something like:
 i2c-1-0067/input0

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
---
 drivers/input/touchscreen/atmel_mxt_ts.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 42e6450..b1108ca 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -250,6 +250,7 @@ struct mxt_finger {
 struct mxt_data {
 	struct i2c_client *client;
 	struct input_dev *input_dev;
+	char phys[64];		/* device physical location */
 	const struct mxt_platform_data *pdata;
 	struct mxt_object *object_table;
 	struct mxt_info info;
@@ -1106,6 +1107,10 @@ static int __devinit mxt_probe(struct i2c_client *client,
 	}
 
 	input_dev->name = "Atmel maXTouch Touchscreen";
+	snprintf(data->phys, sizeof(data->phys), "i2c-%u-%04x/input0",
+		 client->adapter->nr, client->addr);
+	input_dev->phys = data->phys;
+
 	input_dev->id.bustype = BUS_I2C;
 	input_dev->dev.parent = &client->dev;
 	input_dev->open = mxt_input_open;
-- 
1.7.7.3


  reply	other threads:[~2012-06-26  6:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  6:56 [PATCH 00/21 v5] cleanup atmel_mxt_ts Daniel Kurtz
2012-06-26  6:56 ` Daniel Kurtz [this message]
2012-06-26  6:56 ` [PATCH 02/21 v5] Input: atmel_mxt_ts - use client name for irq Daniel Kurtz
2012-06-26  6:56 ` [PATCH 03/21 v5] Input: atmel_mxt_ts - detect OOM when creating mt slots Daniel Kurtz
2012-06-26  6:56 ` [PATCH 04/21 v5] Input: atmel_mxt_ts - warn if sysfs could not be created Daniel Kurtz
2012-06-26  6:56 ` [PATCH 05/21 v5] Input: atmel_mxt_ts - don't read T5 when dumping objects Daniel Kurtz
2012-06-26  6:56 ` [PATCH 06/21 v5] Input: atmel_mxt_ts - use scnprintf for object sysfs entry Daniel Kurtz
2012-06-26  6:56 ` [PATCH 07/21 v5] Input: atmel_mxt_ts - optimize reading objects in " Daniel Kurtz
2012-06-26  6:56 ` [PATCH 08/21 v5] Input: atmel_mxt_ts - print less overhead when dumping objects Daniel Kurtz
2012-06-26  6:56 ` [PATCH 09/21 v5] Input: atmel_mxt_ts - print all instances " Daniel Kurtz
2012-06-27  6:04   ` Henrik Rydberg
2012-06-26  6:56 ` [PATCH 10/21 v5] Input: atmel_mxt_ts - return errors from i2c layer Daniel Kurtz
2012-06-26  6:56 ` [PATCH 11/21 v5] Input: atmel_mxt_ts - add variable length __mxt_write_reg Daniel Kurtz
2012-06-27 18:59   ` Henrik Rydberg
2012-06-26  6:57 ` [PATCH 12/21 v5] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-06-26  6:57 ` [PATCH 13/21 v5] Input: atmel_mxt_ts - read ID information block in one i2c transaction Daniel Kurtz
2012-06-26  6:57 ` [PATCH 14/21 v5] Input: atmel_mxt_ts - update driver ID info logging Daniel Kurtz
2012-06-26  6:57 ` [PATCH 15/21 v5] Input: atmel_mxt_ts - add sysfs entries to read fw and hw version Daniel Kurtz
2012-06-26  6:57 ` [PATCH 16/21 v5] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-06-26  6:57 ` [PATCH 17/21 v5] Input: atmel_mxt_ts - add detail to touchevent debug message Daniel Kurtz
2012-06-26  6:57 ` [PATCH 18/21 v5] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-06-27 19:44   ` Henrik Rydberg
2012-06-26  6:57 ` [PATCH 19/21 v5] Input: atmel_mxt_ts - use T9 reportid range to init number of mt slots Daniel Kurtz
2012-06-27 20:12   ` Henrik Rydberg
2012-06-26  6:57 ` [PATCH 20/21 v5] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-06-26  6:57 ` [PATCH 21/21 v5] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-06-27 20:32   ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340693829-18665-2-git-send-email-djkurtz@chromium.org \
    --to=djkurtz@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=iiro.valkonen@atmel.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miletus@chromium.org \
    --cc=nick.dyer@itdev.co.uk \
    --cc=olofj@chromium.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®