From: Steven Rostedt <rostedt@goodmis.org>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: Re: [PATCH 4/7] tracing/function: Introduce persistent trace option
Date: Wed, 27 Jun 2012 08:40:12 -0400 [thread overview]
Message-ID: <1340800812.16702.3.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1340753009-12483-4-git-send-email-anton.vorontsov@linaro.org>
On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:
>
> @@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int set)
>
> return 0;
> }
> + if (bit == TRACE_FUNC_OPT_PSTORE)
> + return 0;
Perhaps this should be a switch() statement, or at least put a
} else if () {
As it can't be bit == TRACE_FUNC_OPT_STACK and bit ==
TRACE_FUNC_OPT_PSTORE.
-- Steve
>
> return -EINVAL;
> }
next prev parent reply other threads:[~2012-06-27 12:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 23:22 [PATCH v3 0/7] Function tracing support for pstore Anton Vorontsov
2012-06-26 23:23 ` [PATCH 1/7] tracing: Fix initialization failure path in tracing_set_tracer() Anton Vorontsov
2012-06-26 23:23 ` [PATCH 2/7] pstore: Introduce write_buf backend callback Anton Vorontsov
2012-06-26 23:23 ` [PATCH 3/7] pstore: Add persistent function tracing Anton Vorontsov
2012-06-26 23:23 ` [PATCH 4/7] tracing/function: Introduce persistent trace option Anton Vorontsov
2012-06-27 12:40 ` Steven Rostedt [this message]
2012-07-09 23:44 ` Anton Vorontsov
2012-06-26 23:23 ` [PATCH 5/7] pstore/ram: Convert to write_buf callback Anton Vorontsov
2012-06-26 23:23 ` [PATCH 6/7] pstore/ram: Add ftrace messages handling Anton Vorontsov
2012-06-26 23:23 ` [PATCH 7/7] pstore/ram: Make tracing log versioned Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340800812.16702.3.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®