From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757516Ab2F0T1E (ORCPT ); Wed, 27 Jun 2012 15:27:04 -0400 Received: from cpsmtpb-ews03.kpnxchange.com ([213.75.39.6]:2860 "EHLO cpsmtpb-ews03.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756761Ab2F0T05 (ORCPT ); Wed, 27 Jun 2012 15:26:57 -0400 Message-ID: <1340825211.1911.42.camel@x61.thuisdomein> Subject: [PATCH] [SCSI] bnx2i: add a prefix to a printk From: Paul Bolle To: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches Date: Wed, 27 Jun 2012 21:26:51 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-OriginalArrivalTime: 27 Jun 2012 19:26:51.0757 (UTC) FILETIME=[CDC551D0:01CD549A] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During each suspend and resume cycle a mysterious message is added to the logs: CPU 1 offline: Remove Rx thread Some grepping of the tree revealed this message is printed by bnx2i. Add a prefix to this message to make it clear that it is printed by bnx2i. That should also make it obvious it is the mirror of the bnx2i: CPU 1 online: Create Rx thread message. Signed-off-by: Paul Bolle --- 0) Untested! 1) I only noticed this because I've been looking at the log messages generated by suspend and resume (for some iwlegacy and i915 issues) and because Fedora 16 enables bnx2i by default. 2) This triggers a checkpatch warning: WARNING: Prefer pr_info(... to printk(KERN_INFO, ... So I added Joe to the Cc's to suggest a way to make all printks in this file end up with a "bnx2i:" prefix (or whatever prefix is preferred). drivers/scsi/bnx2i/bnx2i_init.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 8b68167..b75864b 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c +++ b/drivers/scsi/bnx2i/bnx2i_init.c @@ -456,7 +456,8 @@ static int bnx2i_cpu_callback(struct notifier_block *nfb, break; case CPU_DEAD: case CPU_DEAD_FROZEN: - printk(KERN_INFO "CPU %x offline: Remove Rx thread\n", cpu); + printk(KERN_INFO "bnx2i: CPU %x offline: Remove Rx thread\n", + cpu); bnx2i_percpu_thread_destroy(cpu); break; default: -- 1.7.7.6