From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653Ab2F1I7h (ORCPT ); Thu, 28 Jun 2012 04:59:37 -0400 Received: from mail-fa0-f74.google.com ([209.85.161.74]:38140 "EHLO mail-fa0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756232Ab2F1I7f (ORCPT ); Thu, 28 Jun 2012 04:59:35 -0400 From: Daniel Kurtz To: Jean Delvare , Ben Dooks , Wolfram Sang , Seth Heasley Cc: Olof Johansson , Benson Leung , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Kurtz Subject: [PATCH] i2c-i801: Clear only status bits in HST_STS after waiting for INTR Date: Thu, 28 Jun 2012 16:59:30 +0800 Message-Id: <1340873970-19226-1-git-send-email-djkurtz@chromium.org> X-Mailer: git-send-email 1.7.7.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Writing back the whole status register could clear unwanted bits. In particular, it could clear the "INUSE_STS" bit, which is a 'hardware semaphore', that might be useful to use some day. To prepare for this, let's ban writing back the whole status to register HST_STS, of which this is the only instance. Signed-off-by: Daniel Kurtz Reported-by: Jean Delvare --- drivers/i2c/busses/i2c-i801.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index ae2945a..7443990 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -301,7 +301,7 @@ static void i801_wait_hwpec(struct i801_priv *priv) if (timeout > MAX_RETRIES) dev_dbg(&priv->pci_dev->dev, "PEC Timeout!\n"); - outb_p(status, SMBHSTSTS(priv)); + outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv)); } static int i801_block_transaction_by_block(struct i801_priv *priv, -- 1.7.7.3