From: David Ahern <dsahern@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] perf: Don't assume host's module path for default guest machine
Date: Sun, 1 Jul 2012 17:55:04 -0600 [thread overview]
Message-ID: <1341186904-66077-1-git-send-email-dsahern@gmail.com> (raw)
When using the default guest modules option (--guestmodules) for perf-kvm
the host's module path is prepended to the modules. e.g,
... PERF_RECORD_MMAP 0/0: [0xffffffffa0005000(0x4fff) @ 0]:
/lib/modules/3.4.0+/kernel/drivers/virtio/virtio.ko
which is wrong so don't do it. With this patch MMAP events for default guest
kernel modules become:
... PERF_RECORD_MMAP 0/0: [0xffffffffa0005000(0x4fff) @ 0]: [virtio]
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
---
tools/perf/util/symbol.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 50958bb..90f6951 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -2077,6 +2077,9 @@ static int machine__create_modules(struct machine *machine)
free(line);
fclose(file);
+ if (machine->pid == DEFAULT_GUEST_KERNEL_ID)
+ return 0;
+
return machine__set_modules_path(machine);
out_delete_line:
--
1.7.10.1
reply other threads:[~2012-07-01 23:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341186904-66077-1-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome