mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Robert Richter <robert.richter@amd.com>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 10/13] perf tools: Fix generation of pmu list
Date: Mon,  2 Jul 2012 17:18:48 -0300	[thread overview]
Message-ID: <1341260331-10204-11-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1341260331-10204-1-git-send-email-acme@infradead.org>

From: Robert Richter <robert.richter@amd.com>

The internal pmu list was never used. With each perf_pmu__find() call
the pmu structure was created new by parsing sysfs. Beside this it
caused memory leaks. We now keep all pmus by adding them to the list.

Also, pmu_lookup() should return pmus that do not expose the format
specifier in sysfs.

We need a valid internal pmu list in a later patch to iterate over all
pmus that exist in the system.

Signed-off-by: Robert Richter <robert.richter@amd.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1339706321-8802-3-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/pmu.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 74d0948e..67715a4 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -72,7 +72,7 @@ static int pmu_format(char *name, struct list_head *format)
 		 "%s/bus/event_source/devices/%s/format", sysfs, name);
 
 	if (stat(path, &st) < 0)
-		return -1;
+		return 0;	/* no error if format does not exist */
 
 	if (pmu_format_parse(path, format))
 		return -1;
@@ -252,6 +252,7 @@ static struct perf_pmu *pmu_lookup(char *name)
 	list_splice(&aliases, &pmu->aliases);
 	pmu->name = strdup(name);
 	pmu->type = type;
+	list_add_tail(&pmu->list, &pmus);
 	return pmu;
 }
 
-- 
1.7.9.2.358.g22243


  parent reply	other threads:[~2012-07-02 20:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 20:18 [GIT PULL 00/13] perf/core fixes and improvements Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 01/13] tools lib traceevent: Fix clean target in Makefile Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 02/13] tools lib traceevent: Teach [ce]tags about libtraceeevent error codes Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 03/13] tools lib traceevent: Make dependency files regeneratable Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 04/13] tools lib traceevent: Check string is really printable Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 05/13] tools lib traceevent: Use local variable 'field' Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 06/13] tools lib traceevent: Add support for __print_hex() Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 07/13] tools lib traceevent: Replace malloc_or_die to plain malloc in alloc_event() Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 08/13] perf tools: Fix hw breakpoint's type modifier parsing Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 09/13] perf evsel: Handle hw breakpoints event names in perf_evsel__name() Arnaldo Carvalho de Melo
2012-07-02 20:18 ` Arnaldo Carvalho de Melo [this message]
2012-07-02 20:18 ` [PATCH 11/13] perf symbols: Add '.note' check into search for NOTE section Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 12/13] perf tools: Adding round_up/round_down macros Arnaldo Carvalho de Melo
2012-07-02 20:18 ` [PATCH 13/13] perf bench: Fix confused variable namings and descriptions in mem subsystem Arnaldo Carvalho de Melo
2012-07-06  8:24 ` [GIT PULL 00/13] perf/core fixes and improvements Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341260331-10204-11-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®