From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030199Ab2GDDCI (ORCPT ); Tue, 3 Jul 2012 23:02:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933208Ab2GDDCF (ORCPT ); Tue, 3 Jul 2012 23:02:05 -0400 From: Cong Wang To: linux-kernel@vger.kernel.org Cc: Andrew Morton , WANG Cong , KOSAKI Motohiro , Mel Gorman , David Rientjes , Rik van Riel , linux-mm@kvack.org Subject: [Patch] mm/policy: use int instead of unsigned for nid Date: Wed, 4 Jul 2012 11:01:38 +0800 Message-Id: <1341370901-14187-1-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: WANG Cong 'nid' should be 'int', not 'unsigned'. Cc: Andrew Morton Cc: KOSAKI Motohiro Cc: Mel Gorman Cc: David Rientjes Cc: Rik van Riel Signed-off-by: WANG Cong --- diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 1d771e4..3cabe81 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1580,9 +1580,9 @@ static struct zonelist *policy_zonelist(gfp_t gfp, struct mempolicy *policy, } /* Do dynamic interleaving for a process */ -static unsigned interleave_nodes(struct mempolicy *policy) +static int interleave_nodes(struct mempolicy *policy) { - unsigned nid, next; + int nid, next; struct task_struct *me = current; nid = me->il_next; @@ -1638,7 +1638,7 @@ unsigned slab_node(struct mempolicy *policy) } /* Do static interleaving for a VMA with known offset. */ -static unsigned offset_il_node(struct mempolicy *pol, +static int offset_il_node(struct mempolicy *pol, struct vm_area_struct *vma, unsigned long off) { unsigned nnodes = nodes_weight(pol->v.nodes); @@ -1658,7 +1658,7 @@ static unsigned offset_il_node(struct mempolicy *pol, } /* Determine a node number for interleave */ -static inline unsigned interleave_nid(struct mempolicy *pol, +static inline int interleave_nid(struct mempolicy *pol, struct vm_area_struct *vma, unsigned long addr, int shift) { if (vma) { @@ -1827,7 +1827,7 @@ out: /* Allocate a page in interleaved policy. Own path because it needs to do special accounting. */ static struct page *alloc_page_interleave(gfp_t gfp, unsigned order, - unsigned nid) + int nid) { struct zonelist *zl; struct page *page; @@ -1876,7 +1876,7 @@ retry_cpuset: cpuset_mems_cookie = get_mems_allowed(); if (unlikely(pol->mode == MPOL_INTERLEAVE)) { - unsigned nid; + int nid; nid = interleave_nid(pol, vma, addr, PAGE_SHIFT + order); mpol_cond_put(pol);