mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH WIP 2/5] xen/arm: set xen_platform_pci_unplug to XEN_UNPLUG_ALL
Date: Wed, 4 Jul 2012 12:49:05 +0100	[thread overview]
Message-ID: <1341402545.31696.50.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207041226150.31911@kaball.uk.xensource.com>

On Wed, 2012-07-04 at 12:27 +0100, Stefano Stabellini wrote:
> On Wed, 4 Jul 2012, David Vrabel wrote:
> > On 04/07/12 12:15, Stefano Stabellini wrote:
> > > Set xen_platform_pci_unplug to XEN_UNPLUG_ALL by default to make
> > > blkfront happy. The parameter doesn't make sense on ARM and should be
> > > removed.
> > 
> > Why is this parameter nonsensical on ARM?  ARM systems can have PCI devices.
> 
> Because we shouldn't assume the presence of a PCI bus on ARM. Moreover
> it would be nice to avoid the ugly unplug protocol entirely if we can.

Also "pci" here refers to the "platform_pci" device not to PCI devices
in general.

SO I think this option is indeed nonsensical at least until such a time
as we have HVM like ARM guests (i.e. ones with a DM emulating specific
platforms) which require a PCI device which serves as the "you are
running under Xen" hook intp to the non-PV aware OSes driver subsystem.
And it's not clear that when we have such guests that a platform pci
device will be the correct solution on ARM anyway.

Ian.



  reply	other threads:[~2012-07-04 11:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 11:14 [PATCH WIP 0/5] xen/arm: grant_table, blkfront and blkback Stefano Stabellini
2012-07-04 11:15 ` [PATCH WIP 1/5] xen/arm: initialize grant_table on ARM Stefano Stabellini
2012-07-04 11:15 ` [PATCH WIP 2/5] xen/arm: set xen_platform_pci_unplug to XEN_UNPLUG_ALL Stefano Stabellini
2012-07-04 11:25   ` David Vrabel
2012-07-04 11:27     ` Stefano Stabellini
2012-07-04 11:49       ` Ian Campbell [this message]
2012-07-04 11:15 ` [PATCH WIP 3/5] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree Stefano Stabellini
2012-07-04 11:15 ` [PATCH WIP 4/5] xen: allow privcmd for hvm guests Stefano Stabellini
2012-07-04 11:15 ` [PATCH WIP 5/5] xen/arm: compile blkfront and blkback Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341402545.31696.50.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®