From: Yadwinder Singh Brar <yadi.brar01@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: sameo@linux.intel.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chiwoong Byun <woong.byun@samsung.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: [PATCH 2/6] mfd: max77686: Apply irq_mask_cur before handling interrupts.
Date: Thu, 5 Jul 2012 09:28:21 +0530 [thread overview]
Message-ID: <1341460705-10868-2-git-send-email-yadi.brar@samsung.com> (raw)
In-Reply-To: <1341460705-10868-1-git-send-email-yadi.brar@samsung.com>
According to TRM, though we mask the interrupts in interrupt-mask register,
interrupt source-register still provide the status of the masked interrupts.
So we should apply irq_mask_cur to read interrupt source-register value before
handling.
Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
drivers/mfd/max77686-irq.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/max77686-irq.c b/drivers/mfd/max77686-irq.c
index 09e593a..0758fac 100644
--- a/drivers/mfd/max77686-irq.c
+++ b/drivers/mfd/max77686-irq.c
@@ -208,6 +208,9 @@ static irqreturn_t max77686_irq_thread(int irq, void *data)
}
+ for (i = 0; i < MAX77686_IRQ_GROUP_NR; i++)
+ irq_reg[i] &= ~max77686->irq_masks_cur[i];
+
for (i = 0; i < MAX77686_IRQ_NR; i++) {
if (irq_reg[max77686_irqs[i].group] & max77686_irqs[i].mask) {
cur_irq = irq_find_mapping(max77686->irq_domain, i);
--
1.7.0.4
next prev parent reply other threads:[~2012-07-05 3:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 3:58 [PATCH 1/6] mfd: max77686: Use pmic regmap to read pmic interrupt register Yadwinder Singh Brar
2012-07-05 3:58 ` Yadwinder Singh Brar [this message]
2012-07-05 3:58 ` [PATCH 3/6] mfd: max77686: Allow to specify interrupt through DT or platform file also Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 4/6] mfd: max77686: Add device tree support Yadwinder Singh Brar
2012-07-05 12:41 ` Mark Brown
2012-07-05 13:37 ` Yadwinder Singh Brar
2012-07-06 8:56 ` [PATCH v2] " Yadwinder Singh Brar
2012-07-06 11:32 ` [PATCH v3] " Yadwinder Singh Brar
2012-07-06 18:09 ` Mark Brown
2012-07-05 3:58 ` [PATCH 5/6] mfd: max77686: Remove the clocks from the list of regulators Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 6/6] regulator: max77686: Add device tree support Yadwinder Singh Brar
2012-07-05 12:42 ` Mark Brown
2012-07-09 11:25 ` [PATCH 1/6] mfd: max77686: Use pmic regmap to read pmic interrupt register Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341460705-10868-2-git-send-email-yadi.brar@samsung.com \
--to=yadi.brar01@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=woong.byun@samsung.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®