From: Valentin Ilie <valentin.ilie@gmail.com>
To: paul.gortmaker@windriver.com, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, Valentin Ilie <valentin.ilie@gmail.com>
Subject: [PATCH] Kernel: dma.c: fixed coding style issues
Date: Sun, 8 Jul 2012 13:51:05 +0300 [thread overview]
Message-ID: <1341744665-15678-1-git-send-email-valentin.ilie@gmail.com> (raw)
Fixed coding style issues. (checkpatch warnings)
Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
---
kernel/dma.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/kernel/dma.c b/kernel/dma.c
index 6c6262f..082cd74 100644
--- a/kernel/dma.c
+++ b/kernel/dma.c
@@ -38,6 +38,7 @@
DEFINE_SPINLOCK(dma_spin_lock);
+EXPORT_SYMBOL(dma_spin_lock);
/*
* If our port doesn't define this it has no PC like DMA
@@ -66,7 +67,7 @@ static struct dma_chan dma_chan_busy[MAX_DMA_CHANNELS] = {
* @dmanr: DMA channel number
* @device_id: reserving device ID string, used in /proc/dma
*/
-int request_dma(unsigned int dmanr, const char * device_id)
+int request_dma(unsigned int dmanr, const char *device_id)
{
if (dmanr >= MAX_DMA_CHANNELS)
return -EINVAL;
@@ -87,12 +88,12 @@ int request_dma(unsigned int dmanr, const char * device_id)
void free_dma(unsigned int dmanr)
{
if (dmanr >= MAX_DMA_CHANNELS) {
- printk(KERN_WARNING "Trying to free DMA%d\n", dmanr);
+ pr_warn("Trying to free DMA%d\n", dmanr);
return;
}
if (xchg(&dma_chan_busy[dmanr].lock, 0) == 0) {
- printk(KERN_WARNING "Trying to free free DMA%d\n", dmanr);
+ pr_warn("Trying to free free DMA%d\n", dmanr);
return;
}
@@ -104,12 +105,14 @@ int request_dma(unsigned int dmanr, const char *device_id)
{
return -EINVAL;
}
+EXPORT_SYMBOL(request_dma);
void free_dma(unsigned int dmanr)
{
}
+EXPORT_SYMBOL(free_dma);
-#endif
+#endif /* MAX_DMA_CHANNELS */
#ifdef CONFIG_PROC_FS
@@ -153,8 +156,4 @@ static int __init proc_dma_init(void)
}
__initcall(proc_dma_init);
-#endif
-
-EXPORT_SYMBOL(request_dma);
-EXPORT_SYMBOL(free_dma);
-EXPORT_SYMBOL(dma_spin_lock);
+#endif /* CONFIG_PROC_FS */
--
1.7.10.4
reply other threads:[~2012-07-08 10:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341744665-15678-1-git-send-email-valentin.ilie@gmail.com \
--to=valentin.ilie@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®