From: David Lechner <david@lechnology.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 3/9] ARM: davinci: da850-evm: use aemif platform driver in legacy mode
Date: Mon, 25 Jun 2018 11:00:11 -0500 [thread overview]
Message-ID: <13418bf6-dbe7-5091-b5a7-07f779fb9f63@lechnology.com> (raw)
In-Reply-To: <20180625152920.11549-4-brgl@bgdev.pl>
On 06/25/2018 10:29 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We now support board files in the aemif driver. Register a platform
> device instead of using the handcrafted API in da850-evm.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> - iounmap(aemif_addr);
> -}
> +static struct platform_device da850_evm_aemif_device = {
> + .name = "ti-aemif",
> + .dev = {
> + .platform_data = &da850_evm_aemif_pdata,
> + },
> + .resource = da850_evm_aemif_resource,
> + .num_resources = ARRAY_SIZE(da850_evm_aemif_resource),
> + .id = -1,
> +};
>
Not essential, but it is nice to have the id right after name
since they are closely related (as you did in several other
instances in this same patch). For a second, I thought you
forgot id = -1 here before I saw it.
next prev parent reply other threads:[~2018-06-25 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:29 [PATCH 0/9] ARM: davinci: deduplicate aemif support Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 1/9] clk: davinci: psc-dm365: use two lookup entries for the aemif clock Bartosz Golaszewski
2018-06-25 15:53 ` David Lechner
2018-06-25 16:01 ` Bartosz Golaszewski
2018-06-25 16:06 ` David Lechner
2018-06-25 16:09 ` Bartosz Golaszewski
2018-06-26 8:27 ` Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 2/9] ARM: davinci: omapl138-hawk: add aemif & nand support Bartosz Golaszewski
2018-06-25 16:08 ` David Lechner
2018-06-25 15:29 ` [PATCH 3/9] ARM: davinci: da850-evm: use aemif platform driver in legacy mode Bartosz Golaszewski
2018-06-25 16:00 ` David Lechner [this message]
2018-06-25 16:04 ` David Lechner
2018-06-25 15:29 ` [PATCH 4/9] ARM: davinci: dm365-evm: use the ti-aemif soc driver Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 5/9] ARM: davinci: dm644x-evm: use aemif platform driver Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 6/9] ARM: davinci: da830-evm: " Bartosz Golaszewski
2018-06-25 16:20 ` David Lechner
2018-06-25 16:23 ` Bartosz Golaszewski
2018-06-25 16:29 ` David Lechner
2018-06-25 15:29 ` [PATCH 7/9] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 8/9] ARM: davinci: mityomapl138: " Bartosz Golaszewski
2018-06-25 15:29 ` [PATCH 9/9] ARM: davinci: kill davinci_aemif_setup() Bartosz Golaszewski
2018-06-25 16:23 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13418bf6-dbe7-5091-b5a7-07f779fb9f63@lechnology.com \
--to=david@lechnology.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®