From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: nhorman@tuxdriver.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, lizefan@huawei.com, tj@kernel.org,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v2] net: cgroup: fix access the unallocated memory in netprio cgroup
Date: Tue, 10 Jul 2012 13:05:50 +0200 [thread overview]
Message-ID: <1341918350.3265.4830.camel@edumazet-glaptop> (raw)
In-Reply-To: <1341917043-13264-1-git-send-email-gaofeng@cn.fujitsu.com>
On Tue, 2012-07-10 at 18:44 +0800, Gao feng wrote:
> there are some out of bound accesses in netprio cgroup.
> - update_netdev_tables();
> + ret = extend_netdev_table(dev, max_len);
> + if (ret < 0)
> + goto out_free_devname;
> +
> ret = 0;
> rcu_read_lock();
> map = rcu_dereference(dev->priomap);
Its unfortunately adding a bug.
extend_netdev_table() is protected by RTNL.
next prev parent reply other threads:[~2012-07-10 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:44 Gao feng
2012-07-10 11:05 ` Eric Dumazet [this message]
2012-07-10 11:08 ` Eric Dumazet
2012-07-11 1:39 ` Gao feng
2012-07-10 11:32 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341918350.3265.4830.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®