mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Drewry <wad@chromium.org>
To: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Cc: fengxj325@gmail.com, eparis@redhat.com, keescook@chromium.org,
	james.l.morris@oracle.com, hpa@zytor.com, cevans@chromium.org,
	luto@mit.edu, rob@landley.net, linux-doc@vger.kernel.org,
	Will Drewry <wad@chromium.org>
Subject: [PATCH 3/3] Documentation: add a caveat for seccomp filter and vsyscall emulation
Date: Sat, 14 Jul 2012 10:32:54 -0500	[thread overview]
Message-ID: <1342279974-26917-3-git-send-email-wad@chromium.org> (raw)
In-Reply-To: <1342279974-26917-1-git-send-email-wad@chromium.org>

With the addition of seccomp support to vsyscall emulation:
  http://permalink.gmane.org/gmane.linux.kernel/1327732
and the prior patch in this series.

Update the documentation to indicate quirky behaviors when the 'ip' is
in the vsyscall page and vsyscall emulation is in effect.

Signed-off-by: Will Drewry <wad@chromium.org>
---
 Documentation/prctl/seccomp_filter.txt |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/Documentation/prctl/seccomp_filter.txt b/Documentation/prctl/seccomp_filter.txt
index 597c3c5..67ed88b 100644
--- a/Documentation/prctl/seccomp_filter.txt
+++ b/Documentation/prctl/seccomp_filter.txt
@@ -161,3 +161,25 @@ architecture supports both ptrace_event and seccomp, it will be able to
 support seccomp filter with minor fixup: SIGSYS support and seccomp return
 value checking.  Then it must just add CONFIG_HAVE_ARCH_SECCOMP_FILTER
 to its arch-specific Kconfig.
+
+
+Caveats
+-------
+
+On x86-64 with vsyscall emulation enabled and while servicing a
+vsyscall-emulated system call:
+- A return value of SECCOMP_RET_TRAP will set a si_call_addr pointing to
+  the vsyscall entry for the given call and not the address after the
+  'syscall' instruction.  Any code which wants to restart the call
+  should return to that address and code wishing to return simulating
+  completion may either sigreturn normally or simulate a ret instruction
+  and use the return address from the stack.
+- A return value of SECCOMP_RET_TRACE will signal the tracer as usual,
+  but the syscall may not be changed to another system call using the
+  orig_rax register. It may only be changed to a different value in
+  order to skip the currently emulated call and any change will result
+  in that behavior.  The remainder of the registers may be altered as
+  usual.
+- Detection of this quirky behavior may be done by checking for getcpu,
+  time, or gettimeofday and if the si_call_addr or rip is in the
+  vsyscall page, specifically at the start of the specific entry call.
-- 
1.7.9.5


      parent reply	other threads:[~2012-07-14 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-14 15:32 [PATCH 1/3] vsyscall_64: add missing ifdef CONFIG_SECCOMP Will Drewry
2012-07-14 15:32 ` [PATCH 2/3] vsyscall_64: allow SECCOMP_RET_TRACErs to skip Will Drewry
     [not found]   ` <CAObL_7GX0q_qywY4g1S2iRZWPS95ar01wtvv9wDW=zswwaZ6fQ@mail.gmail.com>
2012-07-14 15:50     ` Will Drewry
2012-07-14 15:57       ` Will Drewry
2012-07-14 16:15         ` Andrew Lutomirski
2012-07-14 16:21           ` Andrew Lutomirski
2012-07-14 16:55             ` Will Drewry
2012-08-10  9:14               ` James Morris
2012-08-13 18:17                 ` Andrew Lutomirski
2012-07-14 15:32 ` Will Drewry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342279974-26917-3-git-send-email-wad@chromium.org \
    --to=wad@chromium.org \
    --cc=cevans@chromium.org \
    --cc=eparis@redhat.com \
    --cc=fengxj325@gmail.com \
    --cc=hpa@zytor.com \
    --cc=james.l.morris@oracle.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=rob@landley.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®