From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: "Jovi Zhang" <bookjovi@gmail.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Ingo Molnar" <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: using pr_fmt for better printk output
Date: Tue, 17 Jul 2012 00:25:25 -0400 [thread overview]
Message-ID: <1342499125.24525.11.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1342496521.8377.105.camel@joe2Laptop>
On Mon, 2012-07-16 at 20:42 -0700, Joe Perches wrote:
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> []
> > @@ -13,6 +13,8 @@
> > * Copyright (C) 2004 William Lee Irwin III
> > */
> >
> > +#define pr_fmt(fmt) "ftrace: " fmt
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Wouldn't a nicer patch be to move this into a header file and then
remove all the defines throughout the kernel tree?
Also, what is KBUILD_MODNAME defined as for non-modules? As ftrace is
not a module.
-- Steve
next prev parent reply other threads:[~2012-07-17 4:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 1:15 Jovi Zhang
2012-07-17 3:42 ` Joe Perches
2012-07-17 4:25 ` Steven Rostedt [this message]
2012-07-17 5:07 ` Joe Perches
2012-07-17 5:32 ` Jovi Zhang
2012-07-17 5:37 ` Joe Perches
2012-07-17 6:47 ` Jovi Zhang
2012-07-17 5:23 ` Jovi Zhang
2012-07-17 5:27 ` Joe Perches
2012-07-17 5:29 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342499125.24525.11.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=bookjovi@gmail.com \
--cc=fweisbec@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®