From: "Theodore Ts'o" <tytso@mit.edu>
To: Linux Kernel Developers List <linux-kernel@vger.kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: [PATCH 14/17] [ARM] pxa: remove IRQF_SAMPLE_RANDOM which is now a no-op
Date: Tue, 17 Jul 2012 17:32:33 -0400 [thread overview]
Message-ID: <1342560756-18737-15-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1342560756-18737-1-git-send-email-tytso@mit.edu>
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
---
arch/arm/mach-pxa/lubbock.c | 2 +-
arch/arm/mach-pxa/magician.c | 5 ++---
arch/arm/mach-pxa/trizeps4.c | 4 ++--
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-pxa/lubbock.c b/arch/arm/mach-pxa/lubbock.c
index 6bb3f47..0ca0db7 100644
--- a/arch/arm/mach-pxa/lubbock.c
+++ b/arch/arm/mach-pxa/lubbock.c
@@ -456,7 +456,7 @@ static int lubbock_mci_init(struct device *dev,
init_timer(&mmc_timer);
mmc_timer.data = (unsigned long) data;
return request_irq(LUBBOCK_SD_IRQ, lubbock_detect_int,
- IRQF_SAMPLE_RANDOM, "lubbock-sd-detect", data);
+ 0, "lubbock-sd-detect", data);
}
static int lubbock_mci_get_ro(struct device *dev)
diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c
index 2db697c..39561dc 100644
--- a/arch/arm/mach-pxa/magician.c
+++ b/arch/arm/mach-pxa/magician.c
@@ -633,9 +633,8 @@ static struct platform_device bq24022 = {
static int magician_mci_init(struct device *dev,
irq_handler_t detect_irq, void *data)
{
- return request_irq(IRQ_MAGICIAN_SD, detect_irq,
- IRQF_DISABLED | IRQF_SAMPLE_RANDOM,
- "mmc card detect", data);
+ return request_irq(IRQ_MAGICIAN_SD, detect_irq, IRQF_DISABLED,
+ "mmc card detect", data);
}
static void magician_mci_exit(struct device *dev, void *data)
diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c
index 2b6ac00..166dd32 100644
--- a/arch/arm/mach-pxa/trizeps4.c
+++ b/arch/arm/mach-pxa/trizeps4.c
@@ -332,8 +332,8 @@ static int trizeps4_mci_init(struct device *dev, irq_handler_t mci_detect_int,
int err;
err = request_irq(TRIZEPS4_MMC_IRQ, mci_detect_int,
- IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_SAMPLE_RANDOM,
- "MMC card detect", data);
+ IRQF_DISABLED | IRQF_TRIGGER_RISING,
+ "MMC card detect", data);
if (err) {
printk(KERN_ERR "trizeps4_mci_init: MMC/SD: can't request"
"MMC card detect IRQ\n");
--
1.7.11.1.108.gb129051
next prev parent reply other threads:[~2012-07-17 22:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
2012-07-17 21:32 ` [PATCH 01/17] mfd: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
2012-07-17 21:32 ` [PATCH 02/17] input/serio/hp_sdc.c: " Theodore Ts'o
2012-07-18 6:09 ` Dmitry Torokhov
2012-07-18 17:05 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 03/17] i2c-pmcmsp: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 04/17] pda_power: " Theodore Ts'o
2012-07-18 4:00 ` Anton Vorontsov
2012-07-18 4:18 ` Theodore Ts'o
2012-07-18 4:56 ` Anton Vorontsov
2012-07-17 21:32 ` [PATCH 05/17] n2_crypto: " Theodore Ts'o
2012-07-18 0:48 ` Herbert Xu
2012-07-17 21:32 ` [PATCH 06/17] xen-blkfront: " Theodore Ts'o
2012-07-19 19:44 ` Konrad Rzeszutek Wilk
2012-07-17 21:32 ` [PATCH 07/17] drivers: hv: " Theodore Ts'o
2012-07-18 13:14 ` KY Srinivasan
2012-07-17 21:32 ` [PATCH 08/17] uartlite: " Theodore Ts'o
2012-07-18 4:41 ` Peter Korsgaard
2012-07-17 21:32 ` [PATCH 09/17] goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out Theodore Ts'o
2012-07-17 21:32 ` [PATCH 10/17] omap_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
2012-07-17 21:32 ` [PATCH 11/17] pxa25x_udc: " Theodore Ts'o
2012-07-19 3:07 ` Haojian Zhuang
2012-07-17 21:32 ` [PATCH 12/17] isp1301_omap: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 13/17] board-palmz71: " Theodore Ts'o
2012-07-17 21:32 ` Theodore Ts'o [this message]
2012-07-19 3:08 ` [PATCH 14/17] [ARM] pxa: " Haojian Zhuang
2012-07-17 21:32 ` [PATCH 15/17] sparc/ldc: " Theodore Ts'o
2012-07-17 22:06 ` David Miller
2012-07-17 21:32 ` [PATCH 16/17] um: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 17/17] random: final removal of IRQF_SAMPLE_RANDOM Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342560756-18737-15-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®