From: <gregkh@linuxfoundation.org>
To: johnstul@us.ibm.com, a.p.zijlstra@chello.nl,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
mingo@kernel.org, prarit@redhat.com, tglx@linutronix.de
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "hrtimers: Move lock held region in hrtimer_interrupt()" has been added to the 3.4-stable tree
Date: Tue, 17 Jul 2012 14:59:19 -0700 [thread overview]
Message-ID: <13425623591800@kroah.org> (raw)
In-Reply-To: <1342507196-54327-5-git-send-email-johnstul@us.ibm.com>
This is a note to let you know that I've just added the patch titled
hrtimers: Move lock held region in hrtimer_interrupt()
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hrtimers-move-lock-held-region-in-hrtimer_interrupt.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From johnstul@us.ibm.com Tue Jul 17 14:27:06 2012
From: John Stultz <johnstul@us.ibm.com>
Date: Tue, 17 Jul 2012 02:39:53 -0400
Subject: hrtimers: Move lock held region in hrtimer_interrupt()
To: stable@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>, John Stultz <johnstul@us.ibm.com>, Prarit Bhargava <prarit@redhat.com>, Linux Kernel <linux-kernel@vger.kernel.org>
Message-ID: <1342507196-54327-5-git-send-email-johnstul@us.ibm.com>
From: Thomas Gleixner <tglx@linutronix.de>
This is a backport of 196951e91262fccda81147d2bcf7fdab08668b40
We need to update the base offsets from this code and we need to do
that under base->lock. Move the lock held region around the
ktime_get() calls. The ktime_get() calls are going to be replaced with
a function which gets the time and the offsets atomically.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Link: http://lkml.kernel.org/r/1341960205-56738-6-git-send-email-johnstul@us.ibm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
kernel/hrtimer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1263,11 +1263,10 @@ void hrtimer_interrupt(struct clock_even
cpu_base->nr_events++;
dev->next_event.tv64 = KTIME_MAX;
+ raw_spin_lock(&cpu_base->lock);
entry_time = now = ktime_get();
retry:
expires_next.tv64 = KTIME_MAX;
-
- raw_spin_lock(&cpu_base->lock);
/*
* We set expires_next to KTIME_MAX here with cpu_base->lock
* held to prevent that a timer is enqueued in our queue via
@@ -1344,6 +1343,7 @@ retry:
* interrupt routine. We give it 3 attempts to avoid
* overreacting on some spurious event.
*/
+ raw_spin_lock(&cpu_base->lock);
now = ktime_get();
cpu_base->nr_retries++;
if (++retries < 3)
@@ -1356,6 +1356,7 @@ retry:
*/
cpu_base->nr_hangs++;
cpu_base->hang_detected = 1;
+ raw_spin_unlock(&cpu_base->lock);
delta = ktime_sub(now, entry_time);
if (delta.tv64 > cpu_base->max_hang_time.tv64)
cpu_base->max_hang_time = delta;
Patches currently in stable-queue which might be from johnstul@us.ibm.com are
queue-3.4/timekeeping-fix-leapsecond-triggered-load-spike-issue.patch
queue-3.4/hrtimer-update-hrtimer-base-offsets-each-hrtimer_interrupt.patch
queue-3.4/timekeeping-add-missing-update-call-in-timekeeping_resume.patch
queue-3.4/hrtimers-move-lock-held-region-in-hrtimer_interrupt.patch
queue-3.4/hrtimer-provide-clock_was_set_delayed.patch
queue-3.4/timekeeping-provide-hrtimer-update-function.patch
queue-3.4/timekeeping-maintain-ktime_t-based-offsets-for-hrtimers.patch
next prev parent reply other threads:[~2012-07-17 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 6:39 [PATCH 0/7] 3.4-stable: Fix for leapsecond caused hrtimer/futex issue John Stultz
2012-07-17 6:39 ` [PATCH 1/7] 3.4.x: hrtimer: Provide clock_was_set_delayed() John Stultz
2012-07-17 21:59 ` Patch "hrtimer: Provide clock_was_set_delayed()" has been added to the 3.4-stable tree gregkh
2012-07-17 6:39 ` [PATCH 2/7] 3.4.x: timekeeping: Fix leapsecond triggered load spike issue John Stultz
2012-07-17 21:59 ` Patch "timekeeping: Fix leapsecond triggered load spike issue" has been added to the 3.4-stable tree gregkh
2012-07-17 6:39 ` [PATCH 3/7] 3.4.x: timekeeping: Maintain ktime_t based offsets for hrtimers John Stultz
2012-07-17 21:59 ` Patch "timekeeping: Maintain ktime_t based offsets for hrtimers" has been added to the 3.4-stable tree gregkh
2012-07-17 6:39 ` [PATCH 4/7] 3.4.x: hrtimers: Move lock held region in hrtimer_interrupt() John Stultz
2012-07-17 21:59 ` gregkh [this message]
2012-07-17 6:39 ` [PATCH 5/7] 3.4.x: timekeeping: Provide hrtimer update function John Stultz
2012-07-17 21:59 ` Patch "timekeeping: Provide hrtimer update function" has been added to the 3.4-stable tree gregkh
2012-07-17 6:39 ` [PATCH 6/7] 3.4.x: hrtimer: Update hrtimer base offsets each hrtimer_interrupt John Stultz
2012-07-17 21:59 ` Patch "hrtimer: Update hrtimer base offsets each hrtimer_interrupt" has been added to the 3.4-stable tree gregkh
2012-07-17 6:39 ` [PATCH 7/7] 3.4.x: timekeeping: Add missing update call in timekeeping_resume() John Stultz
2012-07-17 21:59 ` Patch "timekeeping: Add missing update call in timekeeping_resume()" has been added to the 3.4-stable tree gregkh
2012-07-17 21:29 ` [PATCH 0/7] 3.4-stable: Fix for leapsecond caused hrtimer/futex issue Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13425623591800@kroah.org \
--to=gregkh@linuxfoundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome