mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Avi Kivity <avi@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] Revert "KVM: Export asm-generic/kvm_para.h"
Date: Wed, 18 Jul 2012 11:29:53 +0100	[thread overview]
Message-ID: <1342607393-32254-1-git-send-email-will.deacon@arm.com> (raw)

This reverts commit 56457f38f212344fb38b250cfa7e7311c065022f.

For architectures without asm/kvm_para.h, asm-generic/Kbuild
unconditionally tries to export the non-existent header file, resulting
in failure to build the user headers. Since the logic in
asm-generic/Kbuild.asm will only export the file if it exists (which in
turn causes linux/kvm_para.h to be exported), we can just remove the
unconditional header export.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Avi Kivity <avi@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---

I'm not sure what specific problem the original commit was fixing, so we
may need to solve this another way if there's something I've missed.

 include/asm-generic/Kbuild |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index 2c85a0f..53f91b1 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -8,7 +8,6 @@ header-y += int-ll64.h
 header-y += ioctl.h
 header-y += ioctls.h
 header-y += ipcbuf.h
-header-y += kvm_para.h
 header-y += mman-common.h
 header-y += mman.h
 header-y += msgbuf.h
-- 
1.7.4.1


             reply	other threads:[~2012-07-18 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 10:29 Will Deacon [this message]
2012-07-18 11:58 ` Arnd Bergmann
2012-07-18 12:33   ` Geert Uytterhoeven
2012-07-19  9:37     ` Will Deacon
2012-07-19 21:12       ` Geert Uytterhoeven
2012-07-18 12:38   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342607393-32254-1-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome