From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170Ab2GSGGp (ORCPT ); Thu, 19 Jul 2012 02:06:45 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:34218 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779Ab2GSGGn (ORCPT ); Thu, 19 Jul 2012 02:06:43 -0400 Subject: Re: [RFC PATCH] tun: don't zeroize sock->file on detach From: Eric Dumazet To: Stanislav Kinsbursky Cc: davem@davemloft.net, netdev@vger.kernel.org, ruanzhijie@hotmail.com, linux-kernel@vger.kernel.org In-Reply-To: <20120711114753.24395.53193.stgit@localhost6.localdomain6> References: <20120711114753.24395.53193.stgit@localhost6.localdomain6> Content-Type: text/plain; charset="UTF-8" Date: Thu, 19 Jul 2012 08:06:38 +0200 Message-ID: <1342677998.2626.3844.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-07-11 at 15:48 +0400, Stanislav Kinsbursky wrote: > This is a fix for bug, introduced in 3.4 kernel by commit > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to > oops for non-persistent devices: > > tun_chr_close() > tun_detach() <== tun->socket.file = NULL > tun_free_netdev() > sk_release_sock() > sock_release(sock->file == NULL) > iput(SOCK_INODE(sock)) <== dereference on NULL pointer > > This patch just removes zeroing of socket's file from __tun_detach(). > sock_release() will do this. > > Signed-off-by: Stanislav Kinsbursky > --- > drivers/net/tun.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 987aeef..c1639f3 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -185,7 +185,6 @@ static void __tun_detach(struct tun_struct *tun) > netif_tx_lock_bh(tun->dev); > netif_carrier_off(tun->dev); > tun->tfile = NULL; > - tun->socket.file = NULL; > netif_tx_unlock_bh(tun->dev); > > /* Drop read queue */ > Acked-by: Eric Dumazet Thanks !