From: Joe Perches <joe@perches.com>
To: Betty Dall <betty.dall@hp.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, infinipath@qlogic.com,
roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com
Subject: Re: [PATCH] [Trivial] qib: fix an incorrect message
Date: Thu, 19 Jul 2012 11:03:12 -0700 [thread overview]
Message-ID: <1342720992.1988.24.camel@joe2Laptop> (raw)
In-Reply-To: <1342726459-2199-1-git-send-email-betty.dall@hp.com>
On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote:
> There is a cut and paste typo in the function qib_pci_slot_reset() where
> it prints that the "link_reset" function is called rather than the
> "slot_reset" function. This makes the message misleading.
Hi Betty.
> diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
[]
> @@ -725,7 +725,7 @@ qib_pci_mmio_enabled(struct pci_dev *pdev)
> static pci_ers_result_t
> qib_pci_slot_reset(struct pci_dev *pdev)
> {
> - qib_devinfo(pdev, "QIB link_reset function called, ignored\n");
> + qib_devinfo(pdev, "QIB slot_reset function called, ignored\n");
These sorts of typos can be avoided by using "%s: ", __func__
qib_devinfo(pdev, "QIB %s: called, ignored\n", __func__);
cheers, Joe
next prev parent reply other threads:[~2012-07-19 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 19:34 Betty Dall
2012-07-19 18:03 ` Joe Perches [this message]
2012-07-19 18:56 ` Betty Dall
2012-07-19 19:11 ` Joe Perches
2012-07-19 18:24 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342720992.1988.24.camel@joe2Laptop \
--to=joe@perches.com \
--cc=betty.dall@hp.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®