mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@redhat.com, linux-kernel@vger.kernel.org
Cc: kay@vrfy.com, joe@perches.com, greg@kroah.com,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 0/3] dyndbg: dev_dbg bugfix + 2 trivials
Date: Thu, 19 Jul 2012 13:46:19 -0600	[thread overview]
Message-ID: <1342727183-4520-1-git-send-email-jim.cromie@gmail.com> (raw)

3 patches here, 1st is bugfix, others are trivial.

1- fix __dev_printk, which broke dev_dbg() prefix under CONFIG_DYNAMIC_DEBUG.

2- change dyndbg prefix interfield separator from ':' to '.'

for example (output from test-code, not submitted):
r8169 0000:02:00.0: r8169.rtl_init_one: set-drvdata pdev:ffff880223041000 dev:ffff880220d6a000
hwmon hwmon1: k10temp.k10temp_probe.180: set-drvdata pdev:ffff88022303d000 dev:ffff8801dfd2a000

This improves usability of cut -d: <logfile> for pr_debug() messages,
as field position is less volatile with various uses of dyndbg flags.
Its not perfect:
- dev_dbg on net-devices adds several more colons,
  but this doesnt vary with dyndbg flags. 
- dyndbg=+pfmlt still adds a field vs dyndbg==p (ie no prefix)
- pr_fmt() commonly adds another colon (unchanged with this patch)
  
3- trivial var name change in lib/dynamic_debug.c


Please drop or apply 2,3 as you prefer.

             reply	other threads:[~2012-07-19 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 19:46 Jim Cromie [this message]
2012-07-19 19:46 ` [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug Jim Cromie
2012-07-23 13:07   ` Jason Baron
2012-07-23 17:09     ` Joe Perches
2012-07-23 20:31       ` Jim Cromie
2012-07-19 19:46 ` Jim Cromie
2012-07-19 19:46 ` [PATCH 2/3] dyndbg: in dynamic_emit_prefix, change inter-field separator Jim Cromie
2012-07-19 19:46 ` [PATCH 3/3] dyndbg: change varname verbose_bytes to sz_used Jim Cromie
2012-07-20 20:38 ` [PATCH 0/3] dyndbg: dev_dbg bugfix + 2 trivials Jason Baron
2012-07-20 20:58   ` Greg KH
2012-07-24 21:40   ` Jim Cromie
2012-07-24 22:28     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342727183-4520-1-git-send-email-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=greg@kroah.com \
    --cc=jbaron@redhat.com \
    --cc=joe@perches.com \
    --cc=kay@vrfy.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®