mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: a.p.zijlstra@chello.nl
Cc: tj@kernel.org, alex.shi@intel.com, mingo@kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sched/numa: recovered SD_PERFER_SIBLING on CPU domain
Date: Fri, 20 Jul 2012 14:19:50 +0800	[thread overview]
Message-ID: <1342765190-21540-1-git-send-email-alex.shi@intel.com> (raw)

commit 8e7fbcbc22c(sched: Remove stale power aware scheduling remnants
and dysfunctional knobs) removed SD_PERFER_SIBLING on CPU domain
On numa machine, that causes load_balance didn't perfer LCPU in same
physical CPU package.

It causes some regression on our numa machines from core2 to NHM and SNB.
Recover this domain flag can recover the performance drop.

This recovery doesn't has any bad impact on my all benchmarks specjbb,
kbuild, fio, hackbench .. etc, on all my machines.
Since it is a recovery, I assume it also has no bad impact for other
platforms.

Signed-off-by: Alex Shi <alex.shi@intel.com>
---
 include/linux/topology.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/topology.h b/include/linux/topology.h
index e91cd43..fec12d6 100644
--- a/include/linux/topology.h
+++ b/include/linux/topology.h
@@ -164,6 +164,7 @@ int arch_update_cpu_topology(void);
 				| 0*SD_SHARE_CPUPOWER			\
 				| 0*SD_SHARE_PKG_RESOURCES		\
 				| 0*SD_SERIALIZE			\
+				| 1*SD_PREFER_SIBLING			\
 				,					\
 	.last_balance		= jiffies,				\
 	.balance_interval	= 1,					\
-- 
1.7.5.4


             reply	other threads:[~2012-07-20  6:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  6:19 Alex Shi [this message]
2012-07-20 12:58 ` Peter Zijlstra
2012-07-26 15:07 ` [tip:sched/urgent] sched/numa: Add SD_PERFER_SIBLING to " tip-bot for Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342765190-21540-1-git-send-email-alex.shi@intel.com \
    --to=alex.shi@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®