From: Daniel Mack <zonque@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Daniel Mack <zonque@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>
Subject: [PATCH] gpiolib: fix chip->base handling in of_gpio_simple_xlate()
Date: Sun, 22 Jul 2012 19:10:52 +0200 [thread overview]
Message-ID: <1342977052-7880-1-git-send-email-zonque@gmail.com> (raw)
of_gpio_simple_xlate() is called for each chip when a GPIO is looked up.
When registering several chips off the same DT node (with different pin
offsets) however, the lookup fails as the GPIO number passed in to
of_gpio_simple_xlate() is likely higher than the chip's ->ngpio value.
Fix that by taking into account the chip's ->base value, and return the
relative offset of the pin inside the chip.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@stericsson.com>
---
I'm currently porting the PXA pieces over to DT, and stumbled over what
looks like an obvious bug to me. Correct me if I'm mistaken, but I see
no reason why one shouldn't be able to instanciate several GPIO chips
from a single DT node.
Thanks,
Daniel
drivers/gpio/gpiolib-of.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index d18068a..51bc232 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -147,13 +147,13 @@ int of_gpio_simple_xlate(struct gpio_chip *gc,
if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
return -EINVAL;
- if (gpiospec->args[0] >= gc->ngpio)
+ if (gpiospec->args[0] >= gc->ngpio + gc->base)
return -EINVAL;
if (flags)
*flags = gpiospec->args[1];
- return gpiospec->args[0];
+ return gpiospec->args[0] - gc->base;
}
EXPORT_SYMBOL(of_gpio_simple_xlate);
--
1.7.10.4
next reply other threads:[~2012-07-22 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 17:10 Daniel Mack [this message]
2012-07-23 14:43 ` Daniel Mack
2012-07-24 12:56 ` Arnd Bergmann
2012-07-24 13:04 ` Daniel Mack
2012-07-24 14:08 ` Arnd Bergmann
2012-07-24 15:22 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342977052-7880-1-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome