From: Vivek Trivedi <vtrivedi018@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin McKinney <klmckinney1@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Vivek Trivedi <vtrivedi018@gmail.com>,
Namjae Jeon <linkinjeon@gmail.com>
Subject: [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek
Date: Tue, 24 Jul 2012 21:25:04 +0530 [thread overview]
Message-ID: <1343145304-4555-1-git-send-email-vtrivedi018@gmail.com> (raw)
They're equivalent, but SEEK_SET seems more informative...
Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
---
drivers/staging/bcm/Misc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 8223a69..8fab3ec 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -203,7 +203,7 @@ static int BcmFileDownload(PMINI_ADAPTER Adapter, const char *path, unsigned int
}
oldfs = get_fs();
set_fs(get_ds());
- vfs_llseek(flp, 0, 0);
+ vfs_llseek(flp, 0, SEEK_SET);
set_fs(oldfs);
if (Adapter->bcm_file_readback_from_chip(Adapter->pvInterfaceAdapter, flp, loc)) {
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "Failed to read back firmware!");
--
1.7.1
next reply other threads:[~2012-07-24 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 15:55 Vivek Trivedi [this message]
2012-07-25 1:23 ` Kevin McKinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343145304-4555-1-git-send-email-vtrivedi018@gmail.com \
--to=vtrivedi018@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®