From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: [PATCH 04/16] ext3: nuke write_super from comments
Date: Wed, 25 Jul 2012 18:12:02 +0300 [thread overview]
Message-ID: <1343229134-29487-5-git-send-email-artem.bityutskiy@linux.intel.com> (raw)
In-Reply-To: <1343229134-29487-1-git-send-email-artem.bityutskiy@linux.intel.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
The '->write_super' superblock method is gone, and this patch removes all the
references to 'write_super' from ext3.
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
I expect this patch to be merged via Al Viro's VFS tree.
fs/ext3/inode.c | 8 --------
fs/ext3/super.c | 11 -----------
2 files changed, 19 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 9a4a5c4..a075973 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -3459,14 +3459,6 @@ ext3_reserve_inode_write(handle_t *handle, struct inode *inode,
* inode out, but prune_icache isn't a user-visible syncing function.
* Whenever the user wants stuff synced (sys_sync, sys_msync, sys_fsync)
* we start and wait on commits.
- *
- * Is this efficient/effective? Well, we're being nice to the system
- * by cleaning up our inodes proactively so they can be reaped
- * without I/O. But we are potentially leaving up to five seconds'
- * worth of inodes floating about which prune_icache wants us to
- * write out. One way to fix that would be to get prune_icache()
- * to do a write_super() to free up some memory. It has the desired
- * effect.
*/
int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode)
{
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 8c3a44b..0794bd6 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -64,11 +64,6 @@ static int ext3_freeze(struct super_block *sb);
/*
* Wrappers for journal_start/end.
- *
- * The only special thing we need to do here is to make sure that all
- * journal_end calls result in the superblock being marked dirty, so
- * that sync() will call the filesystem's write_super callback if
- * appropriate.
*/
handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks)
{
@@ -90,12 +85,6 @@ handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks)
return journal_start(journal, nblocks);
}
-/*
- * The only special thing we need to do here is to make sure that all
- * journal_stop calls result in the superblock being marked dirty, so
- * that sync() will call the filesystem's write_super callback if
- * appropriate.
- */
int __ext3_journal_stop(const char *where, handle_t *handle)
{
struct super_block *sb;
--
1.7.10
next prev parent reply other threads:[~2012-07-25 15:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 15:11 R.I.P. pdflush Artem Bityutskiy
2012-07-25 15:11 ` [PATCH 01/16] vfs: kill write_super and sync_supers Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 02/16] Documentation: get rid of write_super Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 03/16] Documentation: fix the VM knobs descritpion WRT pdflush Artem Bityutskiy
2012-07-25 15:12 ` Artem Bityutskiy [this message]
2012-07-25 15:12 ` [PATCH 05/16] ext4: nuke write_super from comments Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 06/16] ext4: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 07/16] btrfs: nuke write_super " Artem Bityutskiy
2012-07-25 15:46 ` cwillu
2012-07-25 16:06 ` Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 08/16] btrfs: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 09/16] jbd/jbd2: nuke write_super " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 10/16] vfs: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 11/16] hfs: nuke write_super " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 12/16] ntfs: " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 13/16] nilfs2: " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 14/16] drbd: nuke pdflush " Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 15/16] gfs2: " Artem Bityutskiy
2012-07-25 15:16 ` Bob Peterson
2012-07-26 9:10 ` Steven Whitehouse
2012-07-26 9:24 ` Artem Bityutskiy
2012-07-25 15:12 ` [PATCH 16/16] UBIFS: " Artem Bityutskiy
2012-08-02 21:27 ` R.I.P. pdflush Jeff Mahoney
2012-08-03 6:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343229134-29487-5-git-send-email-artem.bityutskiy@linux.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®