From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184Ab2GYXbz (ORCPT ); Wed, 25 Jul 2012 19:31:55 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:52982 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751824Ab2GYXby (ORCPT ); Wed, 25 Jul 2012 19:31:54 -0400 Message-ID: <1343259112.11398.4.camel@joe2Laptop> Subject: Re: [PATCH v3 0/4] ACPI: hotplug messages improvement From: Joe Perches To: Toshi Kani Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com Date: Wed, 25 Jul 2012 16:31:52 -0700 In-Reply-To: <1343257978-7085-1-git-send-email-toshi.kani@hp.com> References: <1343257978-7085-1-git-send-email-toshi.kani@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-07-25 at 17:12 -0600, Toshi Kani wrote: > This patchset improves logging messages for ACPI CPU, Memory, and > Container hotplug notify handlers. The patchset introduces a set of > new macro interfaces, acpi_pr_(), and updates the notify > handlers to use them. acpi_pr_() appends "ACPI" prefix and > ACPI object path to the messages, and its usage model is similar to > dev_(). This improves diagnostics in hotplug operations > since it identifies an object that caused an issue in a log file. > > v3: > - Changed acpi_pr_debug() to NOP when !DEBUG and !DYNAMIC_DEBUG. > DYNAMIC_DEBUG will be supported later. > - Added const to a path variable in acpi_printk(). > - Added more descriptions to the change log of patch 1/4. Thanks Toshi. This seems sensible to me. I've no more comments either.