From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936Ab2GZWWQ (ORCPT ); Thu, 26 Jul 2012 18:22:16 -0400 Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:42763 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712Ab2GZWWP (ORCPT ); Thu, 26 Jul 2012 18:22:15 -0400 Subject: Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage From: Andy Walls To: Tim Gardner Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org Date: Thu, 26 Jul 2012 18:21:35 -0400 In-Reply-To: <1343327180-94759-1-git-send-email-tim.gardner@canonical.com> References: <1343327180-94759-1-git-send-email-tim.gardner@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1343341295.2575.18.camel@palomino.walls.org> Mime-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.7.7855,1.0.260,0.0.0000 definitions=2012-07-26_06:2012-07-26,2012-07-26,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1203120001 definitions=main-1207260269 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-devel@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c > index 02c5ade..6ec7705 100644 > --- a/drivers/media/video/ivtv/ivtv-firmware.c > +++ b/drivers/media/video/ivtv/ivtv-firmware.c > @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) > > return res; > } > + > +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); > +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); > +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME file is non-fatal.) I would not want anything in user-space or kernel space preventing the ivtv module from loading, if some of those files don't exist. Regards, Andy