From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106Ab2G0Dcs (ORCPT ); Thu, 26 Jul 2012 23:32:48 -0400 Received: from g1t0029.austin.hp.com ([15.216.28.36]:25326 "EHLO g1t0029.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898Ab2G0Dcq (ORCPT ); Thu, 26 Jul 2012 23:32:46 -0400 Message-ID: <1343359675.3010.539.camel@misato.fc.hp.com> Subject: Re: [PATCH v3 1/4] ACPI: Add acpi_pr_() interfaces From: Toshi Kani To: Bjorn Helgaas Cc: Joe Perches , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com Date: Thu, 26 Jul 2012 21:27:55 -0600 In-Reply-To: References: <1343257978-7085-1-git-send-email-toshi.kani@hp.com> <1343257978-7085-2-git-send-email-toshi.kani@hp.com> <1343336330.3010.496.camel@misato.fc.hp.com> <20120726213730.GA2149@google.com> <1343338982.17538.45.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-07-26 at 15:50 -0600, Bjorn Helgaas wrote: > On Thu, Jul 26, 2012 at 3:43 PM, Joe Perches wrote: > > On Thu, 2012-07-26 at 15:37 -0600, Bjorn Helgaas wrote: > >> PNP0C01:00: new device for \_SB_.PCI0.ISA_.MBIO > >> > >> I fiddled with this a while ago; it would look something like this: > > [] > >> +static noinline_for_stack > >> +char *acpi_name_string(char *buf, char *end, acpi_handle handle, > >> + struct printf_spec spec, const char *fmt) > >> +{ > >> + acpi_status status; > >> + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; > >> + u32 type = ACPI_SINGLE_NAME; > >> + char *p = buf; > >> + > >> + if (fmt[0] == 'A') > >> + type = ACPI_FULL_PATHNAME; > > > > maybe if (fmt[1] == 'f') > > > >> @@ -982,6 +1007,9 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, > >> } > >> > >> switch (*fmt) { > >> + case 'A': > >> + case 'a': > >> + return acpi_name_string(buf, end, ptr, spec, fmt); > > > > There are only so many letters, it might be better to > > just use 'a' and another 'f' after that if necessary > > for "full". > > > > And of course that should be #ifdef'd too > > Yes. I'm hesitant about this approach in general, because I don't > think printing the ACPI path is something we should be doing often. > It's not like a struct resource or a MAC address, where there are > dozens or hundreds of users. I really think we should only print ACPI > paths in one or two places, so adding a %p extension would waste a > letter and encourage the wrong behavior. That's a good point. I agree. So, let's continue to use acpi_pr_() for printing ACPI device path. The use of this interface is limited anyway. Thanks, -Toshi