From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752808Ab2G1PRi (ORCPT ); Sat, 28 Jul 2012 11:17:38 -0400 Received: from hub.kern.lc ([141.0.20.193]:41391 "EHLO hub.kern.lc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401Ab2G1PRh (ORCPT ); Sat, 28 Jul 2012 11:17:37 -0400 X-Greylist: delayed 616 seconds by postgrey-1.27 at vger.kernel.org; Sat, 28 Jul 2012 11:17:36 EDT From: Philipp Kern To: linux-kernel@vger.kernel.org Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, ak@linux.intel.com, Philipp Kern Subject: [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG Date: Sat, 28 Jul 2012 17:06:37 +0200 Message-Id: <1343487997-9047-1-git-send-email-pkern@debian.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ip6_xmit checks if the outgoing packet is larger than the path MTU and emits ICMPv6 packet too big locally if this is the case. Logging this, even at KERN_DEBUG, confuses users. It is also not actually helpful for debugging, given that there is no reference to the connection that triggered this event. Hence move this message to LIMIT_NETDEBUG, as suggested by Andi Kleen back in 2001 (<20010215231715.26269@colin.muc.de>). Signed-off-by: Philipp Kern --- net/ipv6/ip6_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 5b2d63e..707002f 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -241,7 +241,7 @@ int ip6_xmit(struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6, dst->dev, dst_output); } - net_dbg_ratelimited("IPv6: sending pkt_too_big to self\n"); + LIMIT_NETDEBUG("IPv6: sending pkt_too_big to self\n"); skb->dev = dst->dev; icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu); IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)), IPSTATS_MIB_FRAGFAILS); -- 1.7.10.4