From: Suresh Siddha <suresh.b.siddha@intel.com>
To: hpa@zytor.com, james.t.kukunas@linux.intel.com, neilb@suse.de
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [patch] x86, avx: don't use avx instructions with "noxsave" boot param
Date: Mon, 30 Jul 2012 15:46:15 -0700 [thread overview]
Message-ID: <1343688375.3696.597.camel@sbsiddha-desk.sc.intel.com> (raw)
Check the kernel has indeed enabled xsave before using AVX instructions.
Fixes the kernel boot panic with "noxsave" boot parameter.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/include/asm/xor_avx.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/xor_avx.h b/arch/x86/include/asm/xor_avx.h
index 2510d35..77987cd 100644
--- a/arch/x86/include/asm/xor_avx.h
+++ b/arch/x86/include/asm/xor_avx.h
@@ -197,12 +197,12 @@ static struct xor_block_template xor_block_avx = {
#define AVX_XOR_SPEED \
do { \
- if (cpu_has_avx) \
+ if (cpu_has_avx && cpu_has_osxsave) \
xor_speed(&xor_block_avx); \
} while (0)
#define AVX_SELECT(FASTEST) \
- (cpu_has_avx ? &xor_block_avx : FASTEST)
+ ((cpu_has_avx && cpu_has_osxsave) ? &xor_block_avx : FASTEST)
#else
next reply other threads:[~2012-07-30 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 22:46 Suresh Siddha [this message]
2012-07-31 4:20 ` NeilBrown
2012-07-31 4:33 ` H. Peter Anvin
2012-07-31 16:27 ` Suresh Siddha
2012-07-31 16:43 ` H. Peter Anvin
2012-07-31 17:29 ` Suresh Siddha
2012-08-01 10:42 ` NeilBrown
2012-08-08 22:25 ` [tip:x86/urgent] x86, avx: don't use avx instructions with " noxsave" " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343688375.3696.597.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=hpa@zytor.com \
--cc=james.t.kukunas@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®