From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755230Ab2G3XMK (ORCPT ); Mon, 30 Jul 2012 19:12:10 -0400 Received: from mx2.netapp.com ([216.240.18.37]:39497 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042Ab2G3XMH (ORCPT ); Mon, 30 Jul 2012 19:12:07 -0400 X-IronPort-AV: E=Sophos;i="4.77,681,1336374000"; d="scan'208";a="669833077" From: "Myklebust, Trond" To: Stanislav Kinsbursky CC: "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" Subject: Re: [PATCH] SUNRPC: return negative value in case rpcbind client creation error Thread-Topic: [PATCH] SUNRPC: return negative value in case rpcbind client creation error Thread-Index: AQHNbqi8Mfyga7emzkO2K/bN5EhJlA== Date: Mon, 30 Jul 2012 23:12:05 +0000 Message-ID: <1343689924.8362.4.camel@lade.trondhjem.org> References: <20120720114849.23572.91010.stgit@localhost.localdomain> In-Reply-To: <20120720114849.23572.91010.stgit@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.104.60.116] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q6UNCRRR007315 On Fri, 2012-07-20 at 15:57 +0400, Stanislav Kinsbursky wrote: > Without this patch kernel will panic on LockD start, because lockd_up() checks > lockd_up_net() result for negative value. > >From my pow it's better to return negative value from rpcbind routines instead > of replacing all such checks like in lockd_up(). > > Signed-off-by: Stanislav Kinsbursky > --- > net/sunrpc/rpcb_clnt.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c > index 92509ff..a70acae 100644 > --- a/net/sunrpc/rpcb_clnt.c > +++ b/net/sunrpc/rpcb_clnt.c > @@ -251,7 +251,7 @@ static int rpcb_create_local_unix(struct net *net) > if (IS_ERR(clnt)) { > dprintk("RPC: failed to create AF_LOCAL rpcbind " > "client (errno %ld).\n", PTR_ERR(clnt)); > - result = -PTR_ERR(clnt); > + result = PTR_ERR(clnt); > goto out; > } > > @@ -298,7 +298,7 @@ static int rpcb_create_local_net(struct net *net) > if (IS_ERR(clnt)) { > dprintk("RPC: failed to create local rpcbind " > "client (errno %ld).\n", PTR_ERR(clnt)); > - result = -PTR_ERR(clnt); > + result = PTR_ERR(clnt); > goto out; > } Who is supposed to carry this patch? Is it Bruce or is it me? Cheers Trond {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I