mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
	dm-devel@redhat.com
Cc: Kent Overstreet <koverstreet@google.com>,
	tj@kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de,
	drbd-dev@lists.linbit.com, vgoyal@redhat.com,
	mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net
Subject: [PATCH v5 06/12] block: Add an explicit bio flag for bios that own their bvec
Date: Mon,  6 Aug 2012 15:08:35 -0700	[thread overview]
Message-ID: <1344290921-25154-7-git-send-email-koverstreet@google.com> (raw)
In-Reply-To: <1344290921-25154-1-git-send-email-koverstreet@google.com>

This is for the new bio splitting code. When we split a bio, if the
split occured on a bvec boundry we reuse the bvec for the new bio. But
that means bio_free() can't free it, hence the explicit flag.

Signed-off-by: Kent Overstreet <koverstreet@google.com>
---
 fs/bio.c                  |    3 ++-
 include/linux/bio.h       |    5 -----
 include/linux/blk_types.h |    1 +
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/bio.c b/fs/bio.c
index ebc7309..ff34311 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -249,7 +249,7 @@ void bio_free(struct bio *bio)
 		return;
 	}
 
-	if (bio_has_allocated_vec(bio))
+	if (bio_flagged(bio, BIO_OWNS_VEC))
 		bvec_free_bs(bs, bio->bi_io_vec, BIO_POOL_IDX(bio));
 
 	if (bio_integrity(bio))
@@ -321,6 +321,7 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs)
 			goto err_free;
 
 		nr_iovecs = bvec_nr_vecs(idx);
+		bio->bi_flags |= 1 << BIO_OWNS_VEC;
 	}
 out_set:
 	bio->bi_flags |= idx << BIO_POOL_OFFSET;
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 393c87e..484b96e 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -84,11 +84,6 @@ static inline void *bio_data(struct bio *bio)
 	return NULL;
 }
 
-static inline int bio_has_allocated_vec(struct bio *bio)
-{
-	return bio->bi_io_vec && bio->bi_io_vec != bio->bi_inline_vecs;
-}
-
 /*
  * will die
  */
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index d10c2e49..416aae4 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -113,6 +113,7 @@ struct bio {
 #define BIO_MAPPED_INTEGRITY 11/* integrity metadata has been remapped */
 
 #define BIO_RESET_BITS	12	/* Flags starting here get preserved by bio_reset() */
+#define BIO_OWNS_VEC	12	/* bio_free() should free bvec */
 
 #define bio_flagged(bio, flag)	((bio)->bi_flags & (1 << (flag)))
 
-- 
1.7.7.3


  parent reply	other threads:[~2012-08-06 22:11 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 22:08 [PATCH v5 00/12] Block cleanups Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 01/12] block: Generalized bio pool freeing Kent Overstreet
2012-08-08 22:25   ` Tejun Heo
2012-08-09  0:26     ` Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-08-08 22:06   ` Tejun Heo
2012-08-08 23:57     ` Kent Overstreet
2012-08-11  5:24       ` Joseph Glanville
2012-08-13 21:44         ` Kent Overstreet
2012-08-14  5:33   ` Jun'ichi Nomura
2012-08-15 20:46     ` Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 03/12] block: Add bio_reset() Kent Overstreet
2012-08-08 22:11   ` Tejun Heo
2012-08-09  0:07     ` Kent Overstreet
2012-08-09  6:00       ` Tejun Heo
2012-08-09  6:06         ` Kent Overstreet
2012-08-09  6:30           ` Tejun Heo
2012-08-06 22:08 ` [PATCH v5 04/12] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-08-08 22:13   ` Tejun Heo
2012-08-09  0:08     ` Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 05/12] block: Kill bi_destructor Kent Overstreet
2012-08-07  3:19   ` Mike Snitzer
2012-08-09  0:14     ` Kent Overstreet
2012-08-08 22:22   ` Tejun Heo
2012-08-09  0:21     ` Kent Overstreet
2012-08-09  6:05       ` Tejun Heo
2012-08-09  6:12         ` Kent Overstreet
2012-08-09  6:34           ` Tejun Heo
2012-08-15 22:19             ` Kent Overstreet
2012-08-06 22:08 ` Kent Overstreet [this message]
2012-08-08 22:28   ` [PATCH v5 06/12] block: Add an explicit bio flag for bios that own their bvec Tejun Heo
2012-08-06 22:08 ` [PATCH v5 07/12] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 08/12] block: Introduce new bio_split() Kent Overstreet
2012-08-08 22:58   ` Tejun Heo
2012-08-09  1:19     ` Kent Overstreet
2012-08-09  6:44       ` Tejun Heo
2012-08-13 21:55     ` Kent Overstreet
2012-08-13 22:05       ` Tejun Heo
2012-08-08 23:05   ` Tejun Heo
2012-08-09  1:39     ` Kent Overstreet
2012-08-09  7:22       ` Tejun Heo
2012-08-09  7:33         ` Kent Overstreet
2012-08-09 17:32           ` Tejun Heo
2012-08-13 22:09             ` Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 09/12] block: Rework bio_pair_split() Kent Overstreet
2012-08-08 23:09   ` Tejun Heo
2012-08-06 22:08 ` [PATCH v5 10/12] block: Add bio_clone_kmalloc() Kent Overstreet
2012-08-08 23:15   ` Tejun Heo
2012-08-09  1:57     ` Kent Overstreet
2012-08-09  6:55       ` Tejun Heo
2012-08-09  7:02         ` Kent Overstreet
2012-08-09  2:38     ` [PATCH] Consolidate bio_clone_bioset(), bio_kmalloc() Kent Overstreet
2012-08-09  6:56       ` Tejun Heo
2012-08-06 22:08 ` [PATCH v5 11/12] block: Add bio_clone_bioset() Kent Overstreet
2012-08-08 23:21   ` Tejun Heo
2012-08-09  2:56     ` Kent Overstreet
2012-08-09  6:52       ` Tejun Heo
2012-08-09  6:59         ` Kent Overstreet
2012-08-06 22:08 ` [PATCH v5 12/12] block: Only clone bio vecs that are in use Kent Overstreet
2012-08-06 23:16   ` [dm-devel] " Mikulas Patocka
2012-08-08 23:28     ` Tejun Heo
2012-08-08 23:47       ` Muthu Kumar
2012-08-09  3:19         ` Kent Overstreet
2012-08-09  3:25           ` Kent Overstreet
2012-08-10  1:50           ` Muthu Kumar
2012-08-09  7:01         ` Tejun Heo
2012-08-10  2:29           ` Muthu Kumar
2012-08-08 23:30   ` Tejun Heo
2012-08-09  3:06     ` Kent Overstreet
2012-08-09 17:37   ` Tejun Heo
2012-08-13 21:46     ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344290921-25154-7-git-send-email-koverstreet@google.com \
    --to=koverstreet@google.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=neilb@suse.de \
    --cc=sage@newdream.net \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=yehuda@hq.newdream.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome