From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, stable@vger.kernel.org (v3.2+),
Samuel Ortiz <sameo@linux.intel.com>,
Daniel Ribeiro <drwyrm@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: [PATCH 1/6] ARM: pxa: remove irq_to_gpio from ezx-pcap driver
Date: Wed, 8 Aug 2012 14:54:48 +0200 [thread overview]
Message-ID: <1344430493-5304-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1344430493-5304-1-git-send-email-arnd@arndb.de>
The irq_to_gpio function was removed from the pxa platform
in linux-3.2, and this driver has been broken since.
There is actually no in-tree user of this driver that adds
this platform device, but the driver can and does get enabled
on some platforms.
Without this patch, building ezx_defconfig results in:
drivers/mfd/ezx-pcap.c: In function 'pcap_isr_work':
drivers/mfd/ezx-pcap.c:205:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org (v3.2+)
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Daniel Ribeiro <drwyrm@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
---
drivers/mfd/ezx-pcap.c | 2 +-
include/linux/mfd/ezx-pcap.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index 43a76c4..db662e2 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -202,7 +202,7 @@ static void pcap_isr_work(struct work_struct *work)
}
local_irq_enable();
ezx_pcap_write(pcap, PCAP_REG_MSR, pcap->msr);
- } while (gpio_get_value(irq_to_gpio(pcap->spi->irq)));
+ } while (gpio_get_value(pdata->gpio));
}
static void pcap_irq_handler(unsigned int irq, struct irq_desc *desc)
diff --git a/include/linux/mfd/ezx-pcap.h b/include/linux/mfd/ezx-pcap.h
index 40c37216..32a1b5c 100644
--- a/include/linux/mfd/ezx-pcap.h
+++ b/include/linux/mfd/ezx-pcap.h
@@ -16,6 +16,7 @@ struct pcap_subdev {
struct pcap_platform_data {
unsigned int irq_base;
unsigned int config;
+ int gpio;
void (*init) (void *); /* board specific init */
int num_subdevs;
struct pcap_subdev *subdevs;
--
1.7.10
next prev parent reply other threads:[~2012-08-08 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 12:54 [PATCH 0/6] ARM: defconfig build errors Arnd Bergmann
2012-08-08 12:54 ` Arnd Bergmann [this message]
2012-08-08 15:27 ` [PATCH 1/6] ARM: pxa: remove irq_to_gpio from ezx-pcap driver Haojian Zhuang
2012-08-08 12:54 ` [PATCH 2/6] ARM: pxa remove irq_to_gpio from eeti_ts driver Arnd Bergmann
2012-08-08 13:23 ` Daniel Mack
2012-08-08 14:19 ` Arnd Bergmann
2012-08-08 14:22 ` Daniel Mack
2012-08-08 14:38 ` Arnd Bergmann
2012-08-08 15:24 ` Haojian Zhuang
2012-08-08 12:54 ` [PATCH 3/6] ARM: sa1100: include asm/io.h in hackkit leds code Arnd Bergmann
2012-08-08 15:36 ` Russell King - ARM Linux
2012-08-08 17:17 ` Arnd Bergmann
2012-08-08 12:54 ` [PATCH 4/6] ARM: s3c24xx: use new PWM driver Arnd Bergmann
2012-08-08 13:10 ` Kukjin Kim
2012-08-08 14:34 ` Arnd Bergmann
2012-08-09 5:31 ` Kukjin Kim
2012-08-08 12:54 ` [PATCH 5/6] ARM: integrator: include <linux/export.h Arnd Bergmann
2012-08-08 13:24 ` Linus Walleij
2012-08-08 14:01 ` Arnd Bergmann
2012-08-08 12:54 ` [PATCH 6/6] ARM: imx: gpmi-nand depends on mxs-dma Arnd Bergmann
2012-08-08 13:00 ` Dirk Behme
2012-08-08 13:01 ` Fabio Estevam
2012-08-08 13:05 ` Dirk Behme
2012-08-08 13:18 ` Fabio Estevam
2012-08-13 10:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344430493-5304-2-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=drwyrm@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®