From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739Ab2HMNDv (ORCPT ); Mon, 13 Aug 2012 09:03:51 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:7437 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975Ab2HMNDt (ORCPT ); Mon, 13 Aug 2012 09:03:49 -0400 X-Authority-Analysis: v=2.0 cv=ZuBv2qHG c=1 sm=0 a=s5Htg7xnQOKvHEu9STBOug==:17 a=OpT9cpI26MMA:10 a=GWnlZwk_GPcA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=ayC55rCoAAAA:8 a=gotj9a51Ou_1RdEWNZsA:9 a=PUjeQqilurYA:10 a=s5Htg7xnQOKvHEu9STBOug==:117 X-Cloudmark-Score: 0 X-Originating-IP: 72.230.195.127 Message-ID: <1344863027.6935.111.camel@gandalf.stny.rr.com> Subject: Re: [RFC][PATCH 4/4] perf/events: Use helper functions in event assignment to shrink macro size From: Steven Rostedt To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Frederic Weisbecker Date: Mon, 13 Aug 2012 09:03:47 -0400 In-Reply-To: <1344845024.31459.9.camel@twins> References: <20120810034302.758092203@goodmis.org> <20120810034708.589220175@goodmis.org> <1344845024.31459.9.camel@twins> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-08-13 at 10:03 +0200, Peter Zijlstra wrote: > > +void perf_trace_event_submit(void *raw_data, struct ftrace_event_call *event_call, > > + struct perf_trace_event *pe) > > +{ > > + struct hlist_head *head; > > + > > + head = this_cpu_ptr(event_call->perf_events); > > + perf_trace_buf_submit(raw_data, pe->entry_size, pe->rctx, pe->addr, > > + pe->count, &pe->regs, head); > > +} > > Can you make perf_trace_buf_submit() go away? Its reduced to a simple > fwd function and layering another wrapper on top seems like pushing it. You mean just have perf_trace_event_submit() call perf_tp_event() directly? I have no problem with that. Although I may make that into a separate patch to keep this patch as a 'move' and the other patch as the change. Looking at the history of perf_trace_buf_submit(), it use to be more than one function call. But when you inlined perf_swevent_put_recursion_context(), it became just a one2one mapping. I'm assuming that we want to convert all calls to perf_trace_buf_submit()s into perf_tp_event()? -- Steve