mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@amd64.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	"borislav.petkov" <borislav.petkov@amd.com>,
	Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH] perf: Let O= makes handle relative paths
Date: Mon, 13 Aug 2012 10:23:02 -0400	[thread overview]
Message-ID: <1344867782.6935.119.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120813132438.GA18990@aftab.osrc.amd.com>

On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote:

> So wouldn't it make sense to call this ABSOLUTE_O or so then?

That's just because you're russian, and are promoting Vodka! ;-)


Done...

----------

When I did a compile of perf using a relative path for the output
directory, the build failed when it tried to compile libtraceevent. This
is because it continues to use the same relative path when the new
working directory is in a different path.

    SUBDIR ../lib/traceevent/
/bin/sh: line 0: cd: ../../../nobackup/perf/: No such file or directory
Makefile:74: *** output directory "../../../nobackup/perf/" does not exist.  Stop.
make: *** [../../../nobackup/perf///libtraceevent.a] Error 2


Make the path used an absolute path when building perf with O=.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
index bde8521..e90e1b4 100644
--- a/tools/scripts/Makefile.include
+++ b/tools/scripts/Makefile.include
@@ -1,6 +1,7 @@
 ifeq ("$(origin O)", "command line")
-	OUTPUT := $(O)/
-	COMMAND_O := O=$(O)
+	ABSOLUTE_O := $(shell cd $(O) ; pwd)
+	OUTPUT := $(ABSOLUTE_O)/
+	COMMAND_O := O=$(ABSOLUTE_O)
 endif
 
 ifneq ($(OUTPUT),)



  reply	other threads:[~2012-08-13 14:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 13:20 Steven Rostedt
2012-08-13 13:24 ` Borislav Petkov
2012-08-13 14:23   ` Steven Rostedt [this message]
2012-08-13 14:29     ` Borislav Petkov
2012-08-13 18:02       ` Arnaldo Carvalho de Melo
2012-08-15 10:27         ` Borislav Petkov
2012-08-15 13:06           ` Arnaldo Carvalho de Melo
2012-08-15 13:18             ` Borislav Petkov
2012-08-15 14:38               ` Peter Zijlstra
2012-08-15 14:42                 ` Borislav Petkov
2012-08-15 14:59                   ` Arnaldo Carvalho de Melo
2012-08-15 16:39                     ` Borislav Petkov
2012-08-16 16:07                       ` Steven Rostedt
2012-08-16 17:12                         ` Arnaldo Carvalho de Melo
2012-08-21 16:20                       ` [tip:perf/core] perf tools: " tip-bot for Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344867782.6935.119.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=acme@infradead.org \
    --cc=borislav.petkov@amd.com \
    --cc=bp@amd64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung.kim@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®