From: Thai Bui <blquythai@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Thai Bui <blquythai@gmail.com>
Subject: [PATCH 1/1] boot: Put initcall_debug into its own Kconfig option DEBUG_INITCALL
Date: Mon, 13 Aug 2012 13:57:11 -0700 [thread overview]
Message-ID: <1344891431-30869-1-git-send-email-blquythai@gmail.com> (raw)
In-Reply-To: <n>
Putting DEBUG_INITCALL config option to compile out the command-line option
"initcall_debug".
Signed-off-by: Thai Bui <blquythai@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
Documentation/kernel-parameters.txt | 3 ++-
include/linux/init.h | 4 ++++
init/main.c | 2 ++
lib/Kconfig.debug | 9 +++++++++
4 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index d99fd9c..3dbaf15 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1026,7 +1026,8 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
initcall_debug [KNL] Trace initcalls as they are executed. Useful
for working out where the kernel is dying during
- startup.
+ startup. DEBUG_INITCALL needs to be enabled in order
+ for this option to work.
initrd= [BOOT] Specify the location of the initial ramdisk
diff --git a/include/linux/init.h b/include/linux/init.h
index 6b95109..d2f31f1 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -157,7 +157,11 @@ void prepare_namespace(void);
extern void (*late_time_init)(void);
+#ifdef CONFIG_DEBUG_INITCALL
extern bool initcall_debug;
+#else
+static const bool initcall_debug = false;
+#endif /* CONFIG_DEBUG_INITCALL */
#endif
diff --git a/init/main.c b/init/main.c
index ff49a6d..65837f7 100644
--- a/init/main.c
+++ b/init/main.c
@@ -648,8 +648,10 @@ static void __init do_ctors(void)
#endif
}
+#ifdef CONFIG_DEBUG_INITCALL
bool initcall_debug;
core_param(initcall_debug, initcall_debug, bool, 0644);
+#endif /* CONFIG_DEBUG_INITCALL */
static char msgbuf[64];
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8745ac7..424ac93 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -769,6 +769,15 @@ config DEBUG_WRITECOUNT
If unsure, say N.
+config DEBUG_INITCALL
+ bool "Debug initcalls as they are executed"
+ depends on DEBUG_KERNEL
+ help
+ Enable this for tracing initcalls during startup. Useful for working
+ out where the kernel is dying during startup.
+
+ If unsure, say N
+
config DEBUG_MEMORY_INIT
bool "Debug memory initialisation" if EXPERT
default !EXPERT
--
1.7.9.5
next reply other threads:[~2012-08-13 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 20:57 Thai Bui [this message]
2012-08-13 21:07 ` Randy Dunlap
2012-08-13 21:21 ` Konrad Rzeszutek Wilk
2012-08-13 22:11 ` Thai Bui
2012-08-15 18:02 ` Tim Bird
[not found] ` <CAKkTMC5SP6LgWbhtkU_HCBUAfArGuHXtp4mcwi2tFTjZOwVQbA@mail.gmail.com>
2012-08-13 22:39 ` Randy Dunlap
2012-08-14 1:18 ` Josh Triplett
2012-08-14 12:03 ` Josh Boyer
2012-08-14 12:50 ` Josh Triplett
2012-08-14 20:13 ` Randy Dunlap
2012-08-14 20:55 ` Josh Triplett
2012-08-14 21:25 ` Randy Dunlap
2012-08-14 22:14 ` Josh Triplett
2012-08-22 19:02 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344891431-30869-1-git-send-email-blquythai@gmail.com \
--to=blquythai@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome